Clicking "Remove" on an added file does nothing. Seems like removeItemSubmit() now needs a data-row-id to trigger removal. This is not passed in by the FileBrowserWidget when submitting the removal request.

CommentFileSizeAuthor
#5 fix_removing_entities_2786851-1.patch959 bytesreekris
#2 fix_removing_entities_2786851.patch963 bytesreekris
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

reekris created an issue. See original summary.

reekris’s picture

reekris CreditAttribution: reekris commented
FileSize
fix_removing_entities_2786851.patch963 bytes

Here is a patch that adds the row id when submitting the Remove request, which seems to fix the issue for me.

reekris’s picture

reekris CreditAttribution: reekris commented
Status: Active » Needs review
reekris’s picture

reekris CreditAttribution: reekris commented
Status: Needs review » Needs work
reekris’s picture

reekris CreditAttribution: reekris commented
FileSize
fix_removing_entities_2786851-1.patch959 bytes

I was using the wrong value for the row id. Here is a new patch

reekris’s picture

reekris CreditAttribution: reekris commented
Status: Needs work » Needs review
samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
CreditAttribution: samuel.mortenson at Acquia commented
Status: Needs review » Reviewed & tested by the community 
+          '#attributes' => [
+              'data-entity-id' => $entity->getEntityTypeId() . ':' . $entity_id,
+              'data-row-id' => $weight
+          ],

Small nitpick - code standards call for two spaces per tab. Other than that this fixes the bug for me, so marking as RTBC.

slashrsm’s picture

slashrsm CreditAttribution: slashrsm at MD Systems GmbH commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +D8Media

Fixed coding standards and committed. Thanks!

  • slashrsm committed 65369b4 on 8.x-1.x authored by reekris 
    Issue #2786851 by reekris, samuel.mortenson: Fix Removing entities in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.