According to the config menu, the default value for the responsive menu is "checked." But in adminimal_menu_settings.inc, the default value is 'TRUE' (with quotes). Shouldn't it be FALSE?

CommentFileSizeAuthor
#6 2786609-Fixes-default-Slicknav-and-jQuery-settings.patch3.25 KBkyletaylored
#2 2786609-adminimal-default.patch1.66 KBjcisio
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kylesimmonds created an issue. See original summary.

jcisio’s picture

jcisio CreditAttribution: jcisio at Axess Open Web Services for ARTE G.E.I.E. commented
Priority: Normal » Major
Status: Active » Needs review
FileSize
2786609-adminimal-default.patch1.66 KB

So here is the patch. Pump to major because the UI is misleading: when the variable is not set, the UI show it unchecked while it is infact checked.

Status: Needs review » Needs work

The last submitted patch, 2: 2786609-adminimal-default.patch, failed testing.

jcisio’s picture

jcisio CreditAttribution: jcisio at Axess Open Web Services for ARTE G.E.I.E. commented

It failed because there is no tests at all.

jstoller’s picture

jstoller
he/him
CreditAttribution: jstoller as a volunteer and at California Science Center commented
Status: Needs work » Reviewed & tested by the community
kyletaylored’s picture

kyletaylored CreditAttribution: kyletaylored at LevelTen Interactive commented
Related issues: +#2680447: Adminimal menu including duplicate jquery.min.js file
FileSize
2786609-Fixes-default-Slicknav-and-jQuery-settings.patch3.25 KB

I found my original issue over in #2680447: Adminimal menu including duplicate jquery.min.js file, but I can't re-open that ticket and found this is actually related. I updated this patch for some typos, misspellings, and the variables were missing from the hook_uninstall function.

Tess Bakker’s picture

Tess Bakker
they/them
Primary language Dutch
CreditAttribution: Tess Bakker at ezCompany commented
Status: Reviewed & tested by the community » Closed (duplicate)
Related issues: +#2513970: Don't use the string 'TRUE' as a boolean

Duplicate, see #2513970: Don't use the string 'TRUE' as a boolean