Here's the upstream issue:

#2785917: Underscores in CSS IDs for panes are converted to hyphens after 3.6 update

Since people have (understandably) used the IDs they've configured in their custom styling, I think we should include that patch in Panopoly to minimize breakage from this update.

CommentFileSizeAuthor
#9 panopoly_core-css-ids-classes-2786249-9.patch740 bytesdsnopek
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dsnopek created an issue. See original summary.

  • dsnopek committed bb6c064 on 7.x-1.x 
    Update Panopoly Core for Issue #2786249: Panels 3.5 converts user...
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Active » Closed (duplicate)
Parent issue: » #2785843: CSS IDs and classes for panes are potentially rewritten in 3.6 update, breaking themes that rely on them

Duplicate of #2785843: CSS IDs and classes for panes are potentially rewritten in 3.6 update, breaking themes that rely on them.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Closed (duplicate) » Active

Sorry, I missed that Panopoly needs its own issues to handle the distribution separate to the bug in the actual module.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
Status: Active » Fixed

@DamienMcKenna: No worries! :-)

Committed to Panopoly - here's the Travis build: https://travis-ci.org/panopoly/panopoly/builds/153290447

bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
CreditAttribution: bkosborne commented
Title: Panels 3.5 converts user configured CSS IDs from underscores to dashes » Panels 3.6 converts user configured CSS IDs from underscores to dashes

Should I create another issue for fixing CSS classes which are converted to lowercase in Panels 3.6, or re-open this one? It's a bit less critical since it's less likely someone would have used uppercase class names, but you never know.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
Title: Panels 3.6 converts user configured CSS IDs from underscores to dashes » Panels 3.6 converts user configured CSS IDs from underscores to dashes and makes CSS classes lover-case
Status: Fixed » Active

Let's re-open this one because the Panels issue got combined

bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
CreditAttribution: bkosborne commented

Ok - I added another patch to that issue which should fix the strtolower issue for classnames. Obviously it's too late to get into the Panopoly release. Maybe we'll get that committed to Panels 3.7 though.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
Status: Active » Needs review
FileSize
panopoly_core-css-ids-classes-2786249-9.patch740 bytes

Here's a patch that switches to the new patch

  • dsnopek committed 7992e04 on 7.x-1.x 
    Update Panopoly Core for Issue #2786249 by dsnopek: Panels 3.6 converts...
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
Status: Needs review » Fixed

Committed!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.