Closed (fixed)
Project:
Eldir
Version:
7.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
18 Aug 2016 at 11:24 UTC
Updated:
27 Oct 2016 at 14:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
helmo commentedHmm, this seems to happen when you set a custom logo image.
In template.php we check the name and only then set $variables['svg_logo'].
This patch is a quick fix. I hope someone with more theming background can improve it.
Comment #3
rajab natshahComment #4
jacob.embree commentedThis patch checks in every case for the existence of $svg_logo before using it and falls back to $logo if it isn't set. It also removes the "onerror" HTML attribute in those instances because I think that was previously the fall back mechanism that I am now replacing.
Comment #5
helmo commented@jacob.embree from you comment it sounds like you agree with the current patch from #2. Are you working on a better approach that would force to to the 4.x branch?
Other wise I'd like to just commit this next week for the 3.8 Aegir release.
Comment #6
jacob.embree commentedI forgot to upload the patch I did.
I don't actually know the difference between 3.x and 4.x. I just did 4.x because it's the latest, but it applies to both.
Comment #8
helmo commentedThanks, committed.