Something wrong with the svg_logo.

Comments

RajabNatshah created an issue. See original summary.

helmo’s picture

StatusFileSize
new529 bytes

Hmm, this seems to happen when you set a custom logo image.

In template.php we check the name and only then set $variables['svg_logo'].
This patch is a quick fix. I hope someone with more theming background can improve it.

rajab natshah’s picture

Status: Needs work » Needs review
jacob.embree’s picture

Version: 7.x-3.7 » 7.x-4.x-dev

This patch checks in every case for the existence of $svg_logo before using it and falls back to $logo if it isn't set. It also removes the "onerror" HTML attribute in those instances because I think that was previously the fall back mechanism that I am now replacing.

helmo’s picture

@jacob.embree from you comment it sounds like you agree with the current patch from #2. Are you working on a better approach that would force to to the 4.x branch?

Other wise I'd like to just commit this next week for the 3.8 Aegir release.

jacob.embree’s picture

StatusFileSize
new2.49 KB

I forgot to upload the patch I did.
I don't actually know the difference between 3.x and 4.x. I just did 4.x because it's the latest, but it applies to both.

  • helmo committed cb32e7e on 7.x-3.x authored by jacob.embree
    Issue #2786149 by helmo, jacob.embree: Notice: Undefined variable:...
helmo’s picture

Version: 7.x-4.x-dev » 7.x-3.x-dev
Status: Needs review » Fixed

Thanks, committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.