There is a typo in exlusions / exlude, should be exclude / exclusions, etc. No updates are required in Alpha phase :)

Is this required? It could my limited understanding of Drupal 8, but I read that as one of the permissions that should only be granted to fully trusted users. I wouldn't place this in the same context as running PHP etc.

restrict access: TRUE

CommentFileSizeAuthor
#6 exclusions-2785999-6.patch1.4 KBjoyceg
#3 exlusions-2785999-3.patch958 bytesjoyceg
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Alan D. created an issue. See original summary.

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha at Acquia commented
Assigned: Unassigned » joyceg

nice find Alan!

The permission key name should be corrected as its already being corrected in the D7 #2618222: permission spelled wrong

joyceg’s picture

joyceg CreditAttribution: joyceg commented
Assigned: joyceg » naveenvalecha
Status: Active » Needs review
FileSize
exlusions-2785999-3.patch958 bytes
Alan D.’s picture

Alan D. CreditAttribution: Alan D. commented

Sorry, no idea where the documentation is, but just comparing with Core, the "restrict access" setting is not needed

http://cgit.drupalcode.org/drupal/tree/core/modules/node/node.permission...

administer nodes:
  title: 'Administer content'
  description: 'Promote, change ownership, edit revisions, and perform other tasks across all content types.'
  restrict access: true
access content overview:
  title: 'Access the Content overview page'

First permission should only be given to really trusted users, the second just the run of the mill admins. Nothing that this module exposes alters the core information disclosure that would otherwise be available (or at least it shouldn't!)

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha at Acquia commented
Assigned: naveenvalecha » Unassigned
Status: Needs review » Needs work 
+++ b/search_config.permissions.yml
@@ -1,4 +1,4 @@
   restrict access: TRUE

Remove the restrict access from the permissions as well.
These are not highly restricted.

joyceg’s picture

joyceg CreditAttribution: joyceg commented
Status: Needs work » Needs review
FileSize
exclusions-2785999-6.patch1.4 KB
Alan D.’s picture

Alan D. CreditAttribution: Alan D. commented
Status: Needs review » Reviewed & tested by the community

Looks good to me. :)

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha at Acquia commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x-1.x

  • naveenvalecha committed d13f00c on 8.x-1.x authored by joyceg 
    Issue #2785999 by joyceg, Alan D., naveenvalecha: Search Config...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.