Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
If a cron job for example logs a lot, it is possible that the aggregated string is too long for a text field. We could also make the field bigger, but this seemed like a quicker fix.
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#11 | ultimate-cron-message-length-2785447-11.patch | 4.7 KB | tduong |
| |||
#11 | ultimate-cron-message-length-2785447-11-test_only.patch | 1.94 KB | tduong |
#11 | interdiff-2785447-8-11.txt | 1.73 KB | tduong |
#8 | interdiff-2785447-5-8.txt | 2.14 KB | tduong |
#5 | ultimate-cron-message-length.patch | 2.77 KB | Berdir |
|
Comments
Comment #2
BerdirComment #5
BerdirPatch was incomplete.
Comment #6
BerdirComment #7
BerdirSee \Drupal\ultimate_cron\Tests\LoggerWebTest::testLoggerFatal(), we need something similar, a new action that logs a string that is longer than the allowed amount, thn we need to make sure that it is cut of correctly.
Comment #8
tduong CreditAttribution: tduong at MD Systems GmbH commentedProvided test coverage.
Comment #10
Berdirsee below, no need to log an error, we just care about the length here.
this part isn't needed, we don't have any fatals. also the ignore errors stuff above.
you can use ->error(). or lets just use ->notice() here, because this is not really an error.
Comment #11
tduong CreditAttribution: tduong at MD Systems GmbH commentedDone.
Comment #14
BerdirThose can go too:
Committed, thanks!