Problem/Motivation

When introducing configuration on the config/install folder you are adding new dependencies for example the search block has a dependency on the search module so the starterkit can not be installed if the search module is uninstalled.

Proposed resolution

Move block configuration to optional config folder so the blocks will only install if the dependencies are met.

Remaining tasks

Patch

CommentFileSizeAuthor
#5 2785419-delete-config-5.patch9.58 KBrodrigoaguilera
#2 2785419-move-config-1.patch4.59 KBrodrigoaguilera
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rodrigoaguilera created an issue. See original summary.

rodrigoaguilera’s picture

rodrigoaguilera
Primary language Spanish
Location Madrid
CreditAttribution: rodrigoaguilera at Ymbra commented
FileSize
2785419-move-config-1.patch4.59 KB

Here is the patch ins case I didn't explained myself right

rodrigoaguilera’s picture

rodrigoaguilera
Primary language Spanish
Location Madrid
CreditAttribution: rodrigoaguilera at Ymbra commented
Status: Active » Needs review
JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin for ImageX commented

I was wondering about this! Nice catch, Rodrigo!

rodrigoaguilera’s picture

rodrigoaguilera
Primary language Spanish
Location Madrid
CreditAttribution: rodrigoaguilera at Ymbra commented
FileSize
2785419-delete-config-5.patch9.58 KB

I'm having second thoughts on this patch.
I'm developing a multilingual site and this has created a confusing config state where some blocks have been created with langcode: 'en' (because of this yml files) but the rest of the configuration is in another language.

I think because of this the blocks configuration on install should be removed.

frob’s picture

frob
Primary language English
CreditAttribution: frob at Clarity Innovations, Inc. commented

@rodrigoaguilera that sounds like a separate issue. Are you sure that is caused by this patch?

rodrigoaguilera’s picture

rodrigoaguilera
Primary language Spanish
Location Madrid
CreditAttribution: rodrigoaguilera at Ymbra commented

@frob
Yes, the hardcoded language is kind of a different issue. I haven't tested if removing it make drupal set the default language of the site.

frob’s picture

frob
Primary language English
CreditAttribution: frob at Clarity Innovations, Inc. commented
Status: Needs review » Reviewed & tested by the community

This all worked for me. I no longer need to install search before installing my sub-theme.

Patch 1 (from comment #2) is RTBC.