While running update to Metatag 7.x-1.17 version from older ones we were experiencing OOM (Running Out Of Memory) issue on metatag_update_7108 due to large volume of nodes we have in the system and translations. Advice is to move metatag_update_7108 into a batch process.

Please find the patch attached.

CommentFileSizeAuthor
#6 metatag-n2784879-6.patch4.34 KBDamienMcKenna
#2 metatag-7.x-1.7-batch_update-2784879.patch5.15 KBsorinb
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sorinb created an issue. See original summary.

sorinb’s picture

sorinb CreditAttribution: sorinb as a volunteer commented
Issue summary: View changes
FileSize
metatag-7.x-1.7-batch_update-2784879.patch5.15 KB
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Fixed » Needs review

Thanks for this! I'll review it shortly.

BTW please leave the issue status set to "active" when you open a new issue, and then set it to "needs review" if you upload a patch. "Fixed" indicates that a problem/request has been completed and no further work is necessary, which isn't the case here.

Setting the status to "needs review" so the testbot can take a look at the lovely new patch!

Status: Needs review » Needs work

The last submitted patch, 2: metatag-7.x-1.7-batch_update-2784879.patch, failed testing.

gg4’s picture

gg4 CreditAttribution: gg4 commented
Related issues: +#2687309: Performance: I18n integration triggers a lot of db writes
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs work » Needs review
FileSize
metatag-n2784879-6.patch4.34 KB

Rerolled.

gg4’s picture

gg4 CreditAttribution: gg4 commented

Looks like testbot was happy with the #6. Damien, any other obvious concerns from your side?

sorinb’s picture

sorinb CreditAttribution: sorinb as a volunteer commented

Thank you buddy! Will take it in consideration for future
Kind regards,
S.

sorinb’s picture

sorinb CreditAttribution: sorinb as a volunteer commented

@Damine, I had a problem while applying your patch:
vagrant@projects:/var/www/xxx/docroot/sites/all/modules/contrib/metatag$ git apply /var/www/xxx/patches/contrib/metatag-n2784879-6.patch
fatal: corrupt patch at line 116

sorinb’s picture

sorinb CreditAttribution: sorinb as a volunteer commented

Please ignore my last comment.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Version: 7.x-1.17 » 7.x-1.x-dev
Parent issue: » #2758749: Plan for Metatag 7.x-1.18 release

I need to manually test it.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Assigned: sorinb » Unassigned

  • DamienMcKenna committed 64c8e1d on 7.x-1.x authored by sorinb 
    Issue #2784879 by sorinb, DamienMcKenna: Change metatag_update_7108 to...
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Fixed

Committed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.