Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
On the "Manage Display" page for any entity that has DS enabled the cogwheel in the operations section will not display for particular fields (plain textfield, etc). This is a problem when you have the fences module enabled as every field should now have the option to configure the field wrapper elements from the UI.
Comment | File | Size | Author |
---|---|---|---|
#8 | fix-operations-to-show-edit-settings-on-entity-manage-display-2784581-8.patch | 603 bytes | droath |
Comments
Comment #2
droath CreditAttribution: droath commentedComment #3
ndf CreditAttribution: ndf commentedCan be removed from the patch
Does this need a test to prove?
nit: array() must be []
But now you remove this. Won't it break something else?
Comment #4
droath CreditAttribution: droath commented@ndf
I've removed the unnecessary code changes in the patch. As my editor was trying to be smart and update code to follow the PSR-2 standards.
I don't know if a test is needed for this patch. The field UI module is the one that should be defining the field settings_edit key for us. The DS module should be altering those fields in the _ds_field_ui_core_fields() function. Right now it's trumping the settings edit values that were defined by field UI. I could add a condition that would check to ensure that settings_edit key exists, if it doesn't then I can create an empty array. Although I don't think that code is necessary.
Field UI Reference: Drupal\field_ui\Form\EntityDisplayFormBase::buildFieldRow() line: 386.
Comment #8
droath CreditAttribution: droath commentedComment #9
droath CreditAttribution: droath commentedComment #10
Jonah Fenn CreditAttribution: Jonah Fenn commentedThis patch cleared the issue up for me. Thanks!
Comment #11
aspilicious CreditAttribution: aspilicious commented"I could add a condition that would check to ensure that settings_edit key exists, if it doesn't then I can create an empty array. Although I don't think that code is necessary."
Yeas could add the additional check.
And this needs a test to ensure we don't break this again in the future.
If you don't know how to create a patch or if you don't have the time, please tell me.
But any help is welcome... My time is limited :)
Comment #12
aspilicious CreditAttribution: aspilicious commentedComment #15
aspilicious CreditAttribution: aspilicious commentedI thought about this some more, you're right about a test being overkill.
Comment #17
darren.fisher CreditAttribution: darren.fisher at Pivale commentedRan in to this issue today. Confirming that #8 is working for me with latest stable releases of Display Suite and Fences. Many thanks for the solution.