Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Follow-up to #2764687: IpAddressBlockingTest is failing on DrupalCI
Problem/Motivation
Drupal\Tests\ban\Functional\IpAddressBlockingTest is failing consistently on DrupalCI PHP 7 test runs on 8.1.x and 8.2.x for all database types. For example https://www.drupal.org/pift-ci-job/368089.
PHP 7 version on DrupalCI is 7.0.10-dev. I've run this locally on PHP 7.0.6 and it passes. Running DrupalCI locally still results in failure. This suggests that this might be due to a change in PHP.
Proposed resolution
Replace 192.168.1.1 with 1.2.3.3.
Remaining tasks
- Replace 192.168.1.1 with 1.2.3.3 in statistics.test as well
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | d7_-2784561-5.patch | 2.22 KB | GoZ |
| #2 | 2784561.patch | 991 bytes | stefan.r |
Comments
Comment #2
stefan.r CreditAttribution: stefan.r commentedComment #3
Fabianx CreditAttribution: Fabianx as a volunteer and at Tag1 Consulting commentedNeed to fix https://api.drupal.org/api/drupal/modules!statistics!statistics.test/fun... as well, by changing 192.168.1.1 to 1.2.3.3.
Comment #4
Fabianx CreditAttribution: Fabianx as a volunteer and at Tag1 Consulting commentedComment #5
GoZ CreditAttribution: GoZ at Centarro commentedComment #6
Fabianx CreditAttribution: Fabianx as a volunteer and at Tag1 Consulting commentedThank you for your contribution!
Marking for commit, gave me and stefan credit as we re-investigated the issue, then re-found the D8 issue (which took some time).
Comment #8
Fabianx CreditAttribution: Fabianx as a volunteer and at Tag1 Consulting commentedCommitted and pushed to 7.x! Thanks!