fatal error when saving a form with an image widget that has a default image set [#2784287]

Notice: Undefined offset: 0 in Drupal\focal_point\Plugin\Field\FieldWidget\FocalPointImageWidget::process() (line 44 of /modules/focal_point/src/Plugin/Field/FieldWidget/FocalPointImageWidget.php).

Symfony\Component\Routing\Exception\InvalidParameterException: Parameter "fid" for route "focal_point.preview" must match "[^/]++" ("" given) to generate a corresponding URL. in Drupal\Core\Routing\UrlGenerator->doGenerate() (line 193 of /core/lib/Drupal/Core/Routing/UrlGenerator.php).

Visiting a edit form page which would normally display a focal point widget causes a WSOD with the above fatals.

Uninstalling focal point and crop API, then re-installing did not resolve the issue.

Reverting focal point to beta1 resolved the issue.

Site running on D8 8.1.7.

The entity form being is a node with just a few core provided field types, nothing special.

Comment	File	Size	Author
#9	focal_point_fatals_on-2784287-9.patch	1.29 KB	bleen
#9	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 142 pass
#7	focal_point_fatals_on-2784287-7.patch	1.46 KB	bleen
#7	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 142 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

15 August 2016 at 13:09

dpi created an issue. See original summary.

Comment #2

bleen CreditAttribution: bleen at NBCUniversal commented 16 August 2016 at 18:32

I have tried several times to reproduce this ... can you reproduce this on more than one site?

Comment #3

bleen CreditAttribution: bleen at NBCUniversal commented 16 August 2016 at 18:36

This might be the same issue as #2782749: Crop not working on beta2 which I havent been able to reproduce.

Is there any chance that this is an issue with local cache? If you copy the image path (of an image that should have changed but didnt) and open it in a new tab in your browser with ?cachebuster=fgdkjhdgjdkfshgdfskjghfdjkggdfs appended to the URL, does the image suddenly look correct? (If there is already a ?itok=sdgkjhsdgkh then use an "&" instead of a "?" for the cachebuster)

Comment #4

justkristin CreditAttribution: justkristin commented 22 August 2016 at 16:40

We are having this same error now when trying to edit a node that uses focal point for one of the images. If the problem is with crop, can we use focal point without it? It is less important than focal point itself...

Comment #5

justkristin CreditAttribution: justkristin commented 22 August 2016 at 16:49

I was also able to make the fatal go away by backing up to beta1.

Comment #6

caldenjacobs CreditAttribution: caldenjacobs commented 22 August 2016 at 17:33

Same issue here. Downgrading to Beta1 fixed on my end as well.

Comment #7

bleen CreditAttribution: bleen at NBCUniversal commented 22 August 2016 at 20:34

Status:

Active

» Needs review

File	Size
focal_point_fatals_on-2784287-7.patch	1.46 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 142 pass

This patch will definitely fix the issue, but in those cases where the fid cannot be found the preview link will not appear.

Comment #8

bleen CreditAttribution: bleen at NBCUniversal commented 23 August 2016 at 00:04

I *still* cant seem to find any way to reproduce this issue .. can everyone plaese try to give me as much detail as possible to any customizations you might be making to the form where you are seeing this error so I can try to figure this out. Are your fields limited to 1 image or multiple? do you every manipulate form_state in a custom module anywhere? any weird hook form alters? Does this happen EVERY time you load the form or only on Tuesdays? Does it happen only when creating a new entity? Only when updating? Both?

Ideally, someone who is seeing this error and is using an IDE, please set a breakpoint point in FocalPointImageWidget::process and put the values of $item, and $element in a gist so I can see them.

We are having this same error now when trying to edit a node that uses focal point for one of the images. If the problem is with crop, can we use focal point without it? It is less important than focal point itself...

Just for the record, it's the preview functionality that is causing this, not the crop integration ...

Comment #9

bleen CreditAttribution: bleen at NBCUniversal commented 23 August 2016 at 01:06

File	Size
focal_point_fatals_on-2784287-9.patch	1.29 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 142 pass

Hmmm ... it looks like the issue *might* be that in some circumstance (I'm guessing based on another contrib module, or some config that I can't find anywhere) the upload widget that appears below any existing images has a "preview" in its element array for some reason.

Based on that, I think this is a safe solution. Please review....

Comment #10

dpi

Perth, Australia

CreditAttribution: dpi as a volunteer commented 26 August 2016 at 11:27

Re-downloaded beta2, applied patch, the widget appears to be working again.

Comment #11

26 August 2016 at 15:55

bleen committed f961ab5 on 8.x-1.x

Issue #2784287 by bleen: focal_point fatals on attempt to view page...

Comment #12

bleen CreditAttribution: bleen at NBCUniversal commented 26 August 2016 at 15:58

Status:

Needs review

» Fixed

Comment #13

Scott Falconer CreditAttribution: Scott Falconer commented 27 August 2016 at 19:36

This happens for me if I have a default image set for the field. Remove the default image and the issue doesn’t occur. Patch in #9 resolves the issue.

Comment #14

bleen CreditAttribution: bleen at NBCUniversal commented 27 August 2016 at 21:53

Awesome.... Thanks for finally giving me a way to reproduce

Comment #15

dpi

Perth, Australia

CreditAttribution: dpi as a volunteer commented 28 August 2016 at 02:22

I double checked both sites I constructed recently with focal_point, and there are no image fields with default images. Take that as you will...

Comment #16

agentrickard

he/him

English

Georgia (US)

CreditAttribution: agentrickard at Palantir.net commented 30 August 2016 at 16:34

Yes, confirming that this happens if the field has a default image set. In my case:

* Create user profile "picture" field with default image
* Save new account (with default image)
* Try to edit account -- error occurs.

It may be that the original account was created prior to the "preview" functionality being added to the module. I did do an update to beta2 this week. So the field may have been created with beta1, where the preview link doesn't exist, so no problem was reported.