Currently path aliases are not supported, causing the machine route path to always be returned for View display sources that are blocks, or anything not a page.

CommentFileSizeAuthor
#3 2783537-3.patch764 bytesmglaman
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mglaman created an issue. See original summary.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro for Bluespark commented

Need to write patch, but this does it.

      case 'block':
      default:
        $current_path = \Drupal::service('path.current')->getPath();
        if (\Drupal::moduleHandler()->moduleExists('path')) {
          return \Drupal::service('path.alias_manager')->getAliasByPath($current_path);
        }
        else {
          return $current_path;
        }
mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro for Bluespark commented
FileSize
2783537-3.patch764 bytes

Patch! Allows us to use our custom taxonomy term aliases with our implementation of a pretty facet paths.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and commented
Status: Active » Needs review

This looks like a smart solution, setting to NR for testbot, but we should fix #2777483: Unmet dependencies in search api first to get our tests green again.

Status: Needs review » Needs work

The last submitted patch, 3: 2783537-3.patch, failed testing.

The last submitted patch, 3: 2783537-3.patch, failed testing.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and commented
Status: Needs work » Reviewed & tested by the community

As soon as all of our tests are green again, we should commit this.

  • borisson_ committed 675a8b7 on 8.x-1.x authored by mglaman 
    Issue #2783537 by mglaman: facet_source\SearchApiViews::getPath support...
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.