Given the module description, I think it should be expected behaviour that when a user logs in through user/login, the user should be redirected to user/me instead of the core default of user/uid.

CommentFileSizeAuthor
#2 me-redirect_user_login-2782849-2.patch1.22 KBakosipax
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

akosipax created an issue. See original summary.

akosipax’s picture

Status: Active » Needs review
FileSize
1.22 KB
tmin’s picture

Status: Needs review » Needs work

I'm not sure that I agree with the premise of the issue (i.e. it should be expected behaviour that when a user logs in through user/login, the user should be redirected to user/me instead of the core default of user/uid) and even if I did, the proposed patch isn't the way I would go about solving this. The main reason being that a simple module update could break the expected functionality in actual live production sites.

If people agree that this is something that should be added, the proper way to do it imho would be to add a setting in admin/config/people/me which would be by default turned off. People who would want the feature would enable it, and it would give the administrators of sites who want it the option to enable it (without breaking the functionality of sites who do not want it).

Furthermore, isn't the problem that this patch tries to solve solvable already by enabling the option "Rewrite links generated by the drupal menu system" in admin/config/people/me? I haven't tested it, but it seems to me that the module already provides a more generic solution through one of its options so there is no reason to patch it for a specific use-case.

I may be wrong by the way, so I'm kicking the status back to "Needs work" so that @akosipax can at least have a chance to address my concerns.