Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The current plan is to commit all conversion issues opened before 2016-Sept-01, right?
No, that is not the current plan. I have no idea who agreed to that, but it wasn't me and I don't think it was a committer. Let's please continue with the approach @dawehner, @Mile23, and I worked out, and respect my decision that these would not be committed on a per-module basis.
Won't nearly identical changes like this be needed everywhere xpath assertions are used? Not really sure it makes sense to patch them one test at a time?
Commented on #2807237: PHPUnit initiative with the suggestion of scoping to xpath assertions instead of per test. This comment I made above does still apply:
CreditAttribution: claudiu.cristea as a volunteer and at Webikon commented
Status:
Needs review
» Reviewed & tested by the community
@xjm, I don't see a way to this in a single patch. It's not only xpath() but also moving the the classes, namespaces, referring the, base class, etc. Removing the module scope, we end with a huge, unreviewable patch.
Comments
Comment #2
dawehnerLooks perfect reasonable. The if is coming from the initial testing commit.
Comment #3
alexpottPostponing on the outcome of any decision about big-bang patch - see #2782663: Convert web tests to browser tests for syslog module
Comment #4
klausiThe current plan is to commit all conversion issues opened before 2016-Sept-01, right? We need to get a base line of committed browser tests in core to discover further problems with them, see the plan in #2735005: Convert all Simpletest web tests to BrowserTestBase (or UnitTestBase/KernelTestBase).
Comment #5
xjmNo, that is not the current plan. I have no idea who agreed to that, but it wasn't me and I don't think it was a committer. Let's please continue with the approach @dawehner, @Mile23, and I worked out, and respect my decision that these would not be committed on a per-module basis.
Per-module is almost never appropriate issue scope. See https://www.drupal.org/core/scope.
Comment #6
xjmActually, I already marked all these tiny issues as duplicates.
Comment #7
klausi@xjm: to get a base line of running browser tests on the testbot the current proposal is to commit a couple of conversions, see #2735005: Convert all Simpletest web tests to BrowserTestBase (or UnitTestBase/KernelTestBase). Could you comment there to make an alternative proposal?
Comment #9
klausiPatch still applies, uploading again to trigger testbot.
Comment #10
claudiu.cristeaLooks good, just a coding standards nit.
I know there's a proposal for inline comments after code but, as far as I know, it's not yet approved. Let's move the comment on its own line.
Comment #11
jofitz CreditAttribution: jofitz at ComputerMinds commentedMoved the comment onto its own line.
Comment #12
claudiu.cristeaGreat, thank you!
Comment #13
xjmWon't nearly identical changes like this be needed everywhere xpath assertions are used? Not really sure it makes sense to patch them one test at a time?
Comment #14
xjmCommented on #2807237: PHPUnit initiative with the suggestion of scoping to xpath assertions instead of per test. This comment I made above does still apply:
:) Thanks!
Comment #15
claudiu.cristea@xjm, I don't see a way to this in a single patch. It's not only xpath() but also moving the the classes, namespaces, referring the, base class, etc. Removing the module scope, we end with a huge, unreviewable patch.
Comment #17
claudiu.cristeaFailure?
Comment #19
jofitz CreditAttribution: jofitz at ComputerMinds commentedRe-rolled.
Comment #20
jofitz CreditAttribution: jofitz at ComputerMinds commentedRe-setting to RTBC in expectation.
Comment #21
klausiThis introduces long array syntax, but as of now we should only have short array syntax in core.
Comment #22
jofitz CreditAttribution: jofitz at ComputerMinds commentedOoops! I won't jump back to RTBC this time. #Embarrassing
Array syntax corrected.
Comment #25
jofitz CreditAttribution: jofitz at ComputerMinds commentedI forgot to move the file.
Comment #26
boaloysius CreditAttribution: boaloysius as a volunteer commented@Jo Fitzgerald. Why is it that 'interdiff 2782663-22.patch 2782663-25.patch' giving me a blank file?
Comment #27
jofitz CreditAttribution: jofitz at ComputerMinds commented@boaloysius The interdiff is blank because the only difference is the location of the file (that is also why I did not upload an interdiff).
Comment #28
klausiLooks good, thanks!
Comment #29
alexpottCommitted and pushed bd6f8f6 to 8.4.x and ddc8c5b to 8.3.x. Thanks!