Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
With caching enabled the changes on the player settings hosting (self or cloud) do not have any effect over the player.
Proposed resolution
Add the config cache to the jw player render element. Invalidate the caches when the settings have changed.
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | fix_caching_when-2782645-7-interdiff.txt | 3.36 KB | Berdir |
| #7 | fix_caching_when-2782645-7.patch | 4.91 KB | Berdir |
| |||
| #7 | fix_caching_when-2782645-7-test-only.patch | 1.67 KB | Berdir |
| #4 | fix_caching_when-2782645-4.patch | 2.62 KB | johnchque |
| |||
| #4 | fix_caching_when-2782645-4-test-only.patch | 1.54 KB | johnchque |
Comments
Comment #2
johnchqueThis seems to work.
Comment #3
johnchqueComment #4
johnchqueTests added. :) interdiff = test-only patch.
Comment #6
BerdirSo far, so good.
As discussed, lets see if we can test that the library is also updated and provides the correct file now.
Comment #7
BerdirThe new file isn't added because it doesn't exist. But we can ensure that the cdn library is no longer added. Additionally, we don't need to invalidate the config cache tag because that happens automatically. We do need to invalidate library_info, and the correct place to do that is a config subscriber. Then it also works when the config is changed with drush, config import and so on.
Comment #10
BerdirCommitted.