It would be cool, if the module could support Google Analytics Tracking Id.

https://helpdesk.quickpay.net/hc/da/articles/206565007-S%C3%A5dan-forbin...

CommentFileSizeAuthor
#6 issue-278199.patch1.27 KBlsolesen
#3 issue-278199.patch.txt1.29 KBlsolesen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lsolesen created an issue. See original summary.

Xen’s picture

Xen CreditAttribution: Xen commented

Shouldn't be too hard. It's not like it's an unique id per user, so it can be implemented as a new configuration field in the settings.

lsolesen’s picture

lsolesen CreditAttribution: lsolesen commented
Status: Active » Needs review
FileSize
issue-278199.patch.txt1.29 KB
Xen’s picture

Xen CreditAttribution: Xen commented 
+++ b/quickpay.transaction.inc
@@ -240,6 +240,10 @@ class Quickpay {
+      $data['autocapture'] = $options['google_analytics_tracking_id'];

That can't be right. :-)

lsolesen’s picture

lsolesen CreditAttribution: lsolesen commented

I will fix that - however, it might even be an idea to check for the google_analytics module being enabled and automatically use that value. What is your take on this?

lsolesen’s picture

lsolesen CreditAttribution: lsolesen commented
FileSize
issue-278199.patch1.27 KB

Patch just fixing #4

Xen’s picture

Xen CreditAttribution: Xen commented

Sounds good to me, but I think there in that case should be a checkbox in the settings to enable GA tracking (default value: enabled), which is only shown if the GA module is enabled.