Thanks for the great module! Small nitpick found.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

naveenvalecha created an issue. See original summary.

naveenvalecha’s picture

Priority: Normal » Minor
Issue summary: View changes
Status: Active » Needs review
Issue tags: +Novice
FileSize
881 bytes
shrop’s picture

This patch resolves issue #2871931 and includes an update to this issue.

richdykins’s picture

Status: Needs review » Needs work

2780605-2.patch still leaves and issue where the install file is using !url. This throws an error on the status report page.

Also, @shrop the patch you link to cannot be used in conjunction with patches from the issue in issue #2823440

richdykins’s picture

Status: Needs work » Needs review
FileSize
779 bytes

Added new patch that just focuses on fixing the !url problem. Based upon the patch linked to in #3 by @shrop. However, $url is still created as a Url object rather than just setting it as a string.

budimanc’s picture

Status: Needs review » Reviewed & tested by the community

Confirmed that patch on #5 works as expected where after it's applied the url is clickable.

Christopher Riley’s picture

Patch works but will not patch when https://www.drupal.org/files/issues/2018-05-11/undefined-severity-variab... is also in place. Would be nice to see some of these patches committed.

nicksanta’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 8.x-1.x branch. Thanks for your contribution!

https://github.com/nicksantamaria/drupal-username_enumeration_prevention...

  • nicksanta committed 7d00607 on 8.x-1.x authored by richdykins
    Issue #2780605 by naveenvalecha, richdykins: Remove deprecated \Drupal::...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.