CommentFileSizeAuthor
#11 Fix_Drupal_coding_standard_spacing_issues_2780557-11.patch7.69 KBsalvis
#6 Fix_Drupal_coding_standard_spacing_issues_2780557-3.patch9.02 KBprince_kr
#4 Fix_Drupal_coding_standard_spacing_issues_2780557-1.patch9.57 KBprince_kr
#3 Fix_Drupal_coding_standard_spacing_issues_2780557-1.patch9.06 KBprince_kr
#2 Fix_Drupal_coding_standard_spacing_issues_2780557-1.patch8.41 KBprince_kr
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

prince_zyxware created an issue. See original summary.

prince_kr’s picture

prince_kr CreditAttribution: prince_kr at Zyxware Technologies commented
FileSize
Fix_Drupal_coding_standard_spacing_issues_2780557-1.patch8.41 KB

Fixed the spacing issues in the above patch.

prince_kr’s picture

prince_kr CreditAttribution: prince_kr at Zyxware Technologies commented
FileSize
Fix_Drupal_coding_standard_spacing_issues_2780557-1.patch9.06 KB
prince_kr’s picture

prince_kr CreditAttribution: prince_kr at Zyxware Technologies commented
FileSize
Fix_Drupal_coding_standard_spacing_issues_2780557-1.patch9.57 KB

Issue fixed in the above patch.

salvis’s picture

salvis
he/his
CreditAttribution: salvis commented
Version: 7.x-1.5 » 7.x-1.x-dev
Priority: Normal » Minor
Status: Active » Needs work
Issue tags: +Bounty Hunter

#2780575: As per Drupal coding standards, closing php tag should be omitted from code files marked as a duplicate.

Please put all Coding Standards fixes into one patch in one issue thread.

Patches must go against the -dev version and then set Status to "Needs Review".

prince_kr’s picture

prince_kr CreditAttribution: prince_kr at Zyxware Technologies commented
FileSize
Fix_Drupal_coding_standard_spacing_issues_2780557-3.patch9.02 KB

@salvis - Updated the Coding Standards fixes on the below patch. Please review and confirm.

prince_kr’s picture

prince_kr CreditAttribution: prince_kr at Zyxware Technologies commented
Status: Needs work » Active
prince_kr’s picture

prince_kr CreditAttribution: prince_kr at Zyxware Technologies commented
Status: Active » Needs review

The last submitted patch, 4: Fix_Drupal_coding_standard_spacing_issues_2780557-1.patch, failed testing.

jacob.embree’s picture

jacob.embree CreditAttribution: jacob.embree at St. Louis Integration commented
Status: Needs review » Needs work
Issue tags: +Coding standards

Patch doesn't apply.

salvis’s picture

salvis
he/his
CreditAttribution: salvis commented
Status: Needs work » Needs review
FileSize
Fix_Drupal_coding_standard_spacing_issues_2780557-11.patch7.69 KB

Re-rolled the patch.

  • salvis committed 53dc5c9 on 7.x-1.x 
    Issue #2780557 by prince_kr, salvis: Drupal coding standards - spacing...
salvis’s picture

salvis
he/his
CreditAttribution: salvis commented
Status: Needs review » Fixed

Thank you, prince_kr.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.