I have been looking at the timeline collector recently fixing what I can in small steps.

The library definition "timeline" does not make it's dependencies clear 3 are missing!

it should read as

timeline:
  version: 2.0
  js:
    js/timeline.js: {}
  css:
    component:
      css/timeline.css: {}
  dependencies:
    - core/jquery
    - core/drupal
    - core/drupalSettings
    - webprofiler/d3
CommentFileSizeAuthor
#2 timeline-2780537-2.patch385 bytesmartin107
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

martin107 created an issue. See original summary.

martin107’s picture

martin107 CreditAttribution: martin107 commented
Assigned: martin107 » Unassigned
Issue summary: View changes
Status: Active » Needs review
FileSize
timeline-2780537-2.patch385 bytes

patch

martin107’s picture

martin107 CreditAttribution: martin107 commented
Issue summary: View changes

issue summary change "it" becomes "it's"

  • lussoluca committed ff6c19f on 8.x-1.x authored by martin107 
    Issue #2780537 by martin107: The timeline library has missing...
lussoluca’s picture

lussoluca
he/him
Primary language Italian
Location Italy
CreditAttribution: lussoluca at H2H Creative Productions commented
Status: Needs review » Closed (fixed)

Good catch, thanks!
Committed and pushed to 8.x-1.x