[D7] FieldMidity

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxvincer2779871git

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Interesting module!

I'm confused as to what fieldmidity_theme_registry_alter() is doing. You're altering templates from your own module...? Of which there are none anyway...?

I don't see any tpl files in the repo. Have you given the right branch in the git clone command above?

Please fixed the following error:

FILE: /var/www/drupal-7-pareview/pareview_temp/fieldmidity.module
------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
------------------------------------------------------------------------
1 | WARNING | There must be no blank line following an inline comment
36 | WARNING | There must be no blank line following an inline comment
70 | WARNING | Unused variable $settings.
------------------------------------------------------------------------

Automated Review

http://pareview.sh/pareview/httpsgitdrupalorgsandboxvincer2779871git

(-) Git default branch is not set, see the documentation on setting a default branch.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

No: Does not follow the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

No: List of security issues identified.

Coding style & Drupal API usage

1. (*) Remove commented code line from your code. Found // $settings = $display['settings']; // Currently unused, but may be implemented in line no 65 fieldmidity.module. Found in many places check in entire module.
2. (*) t('<a href="#playmidi-') . $item["fid"] . ('"; onclick="MIDIjs.play(') . t("'") . file_create_url($item["uri"]) . t("'") . t(');">'), change to l() (https://api.drupal.org/api/drupal/includes%21common.inc/function/l/7.x)
3. (+) follow Drupal coding standers and fixed the space and indent issues

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi Vincer,

This is not critical issue. but it is incorrect.
Code after RETURN statement cannot be executed on line #21
return your content after break statement.

Thank you for your contribution!

After 2017 March 7 everyone can promote a project to a full project.  A full project has a short project name and a drupal.org/project URL.  It can also have releases (like alpha1 or 1.0).  Edit your sandbox project, and then choose the 'Promote' tab.

https://www.drupal.org/docs/8/understanding-drupal-version-numbers/drupa...
https://www.drupal.org/docs/8/choosing-a-drupal-version/what-do-version-...
https://www.drupal.org/docs/8/understanding-drupal-version-numbers/what-...
https://www.drupal.org/docs/8/choosing-a-drupal-version/release-stable-v...

If you'd like to opt into security coverage, please ensure your module is ready for a full release, and then set this issue back to 'needs review'

Immense apologies for how long it took to get to this review completed.

I am closing this application for the lack for replies. I take the OP just needed to be able to promote the project.