FieldMidity implements MidiJS and LibTiMidityJS libraries in a file field display formatter for Drupal. It plays midi files in your browser, using a sound bank where each voice is downloaded as they are called by the channel information in the midi file at load time. It's very similar to the old midi browser plugins, except that the controller is javascript and the samples are hosted remotely.
Project page:
https://www.drupal.org/sandbox/vincer/2779871
Demo site:
http://fieldmidity.newinelabs.com/
Clone command:
git clone --branch 7.x-1.x https://git.drupal.org/sandbox/vincer/2779871.git fieldmidity
Comments
Comment #2
PA robot CreditAttribution: PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxvincer2779871git
Fixed the git clone URL in the issue summary for non-maintainer users.
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #3
joachim CreditAttribution: joachim commentedInteresting module!
I'm confused as to what fieldmidity_theme_registry_alter() is doing. You're altering templates from your own module...? Of which there are none anyway...?
Comment #4
vincer CreditAttribution: vincer commentedThanks for looking at this.
For fieldmidity_theme_registry_alter(), I'm just using it to override the core field.tpl.php with the module's field--field-midi.tpl.php.
I don't know of another way to do this, or what a better approach might be.
I'm open to any input.
Comment #5
joachim CreditAttribution: joachim commentedI don't see any tpl files in the repo. Have you given the right branch in the git clone command above?
Comment #6
vincer CreditAttribution: vincer commentedLooks like I didn't add it to the repo. Updated. Should be good now.
Comment #7
dilipsingh02 CreditAttribution: dilipsingh02 commentedPlease fixed the following error:
Comment #8
vincer CreditAttribution: vincer commented@dilipsingh02 - fieldmidity.module Is updated with corrections. ty
Comment #9
dilipsingh02 CreditAttribution: dilipsingh02 commentedAutomated Review
http://pareview.sh/pareview/httpsgitdrupalorgsandboxvincer2779871git
(-) Git default branch is not set, see the documentation on setting a default branch.
Manual Review
// $settings = $display['settings']; // Currently unused, but may be implemented
in line no 65 fieldmidity.module. Found in many places check in entire module.t('<a href="#playmidi-') . $item["fid"] . ('"; onclick="MIDIjs.play(') . t("'") . file_create_url($item["uri"]) . t("'") . t(');">'),
change to l() (https://api.drupal.org/api/drupal/includes%21common.inc/function/l/7.x)The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.
If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.
This review uses the Project Application Review Template.
Comment #10
vincer CreditAttribution: vincer commented@dilipsingh02 - I've just committed an update. I believe I've corrected all of the #9 issues.
Comment #11
PA robot CreditAttribution: PA robot commentedClosing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #12
vincer CreditAttribution: vincer commentedComment #13
vincer CreditAttribution: vincer commentedComment #14
vincer CreditAttribution: vincer commentedPareview.sh shows no errors. There are 3 warnings, but I'm not sure that they need to be addressed.
Comment #15
addonsolutions CreditAttribution: addonsolutions commentedHi Vincer,
This is not critical issue. but it is incorrect.
Code after RETURN statement cannot be executed on line #21
return your content after break statement.
Comment #16
vincer CreditAttribution: vincer commentedComment #17
vincer CreditAttribution: vincer commentedRETURN statement cannot be executed issue has been cleared.
Comment #18
Warped CreditAttribution: Warped as a volunteer commentedThank you for your contribution!
After 2017 March 7 everyone can promote a project to a full project. A full project has a short project name and a drupal.org/project URL. It can also have releases (like alpha1 or 1.0). Edit your sandbox project, and then choose the 'Promote' tab.
https://www.drupal.org/docs/8/understanding-drupal-version-numbers/drupa...
https://www.drupal.org/docs/8/choosing-a-drupal-version/what-do-version-...
https://www.drupal.org/docs/8/understanding-drupal-version-numbers/what-...
https://www.drupal.org/docs/8/choosing-a-drupal-version/release-stable-v...
If you'd like to opt into security coverage, please ensure your module is ready for a full release, and then set this issue back to 'needs review'
Immense apologies for how long it took to get to this review completed.
Comment #19
apadernoI am closing this application for the lack for replies. I take the OP just needed to be able to promote the project.