I am splitting off a side issue from

#2768925: Improve WebProfiler Library Dependency Discovery

I noticed that d3 is not injected into timelinejs as it should be.

Currently, the libraries injected ( see bottom of the file ) are

        }
    }

})(jQuery, Drupal, drupalSettings);

This is something that shows up in a javascript lint error check.

As I fixed it up I ran eslint just to check my change.

Unfortunately my changes were buried in a mountain of other lint errors.

Mostly 4 space indentation not 2 -- after I fix that the file was 22% smaller ( down from 8.6 Kbytes )

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

martin107 created an issue. See original summary.

martin107’s picture

Assigned: martin107 » Unassigned
Status: Active » Needs review
FileSize
15.9 KB
martin107’s picture

Title: d3 needs to be injected into timeline.js and lint fixup » d3 should be injected into timeline.js and lint fixup

need is a strong word.

  • lussoluca committed 08c0fe6 on 8.x-1.x authored by martin107
    Issue #2780305 by martin107: d3 should  be injected into timeline.js and...
lussoluca’s picture

Status: Needs review » Closed (fixed)

Committed and pushed to 8.x-1.x