Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I am splitting off a side issue from
#2768925: Improve WebProfiler Library Dependency Discovery
I noticed that d3 is not injected into timelinejs as it should be.
Currently, the libraries injected ( see bottom of the file ) are
}
}
})(jQuery, Drupal, drupalSettings);
This is something that shows up in a javascript lint error check.
As I fixed it up I ran eslint just to check my change.
Unfortunately my changes were buried in a mountain of other lint errors.
Mostly 4 space indentation not 2 -- after I fix that the file was 22% smaller ( down from 8.6 Kbytes )
Comment | File | Size | Author |
---|---|---|---|
#2 | lint-inject-2780305-2.patch | 15.9 KB | martin107 |
|
Comments
Comment #2
martin107 CreditAttribution: martin107 commentedComment #3
martin107 CreditAttribution: martin107 commentedneed is a strong word.
Comment #5
lussolucaCommitted and pushed to 8.x-1.x