Port Shield Pages Settings from d7 to d8

CommentFileSizeAuthor
#10 interdiff-9-10.txt1.25 KBnaveenvalecha
#4 2780215-4.patch351 bytesManjit.Singh
#7 shield_pages-add_config_page-2780215-7.patch7.58 KBalan-ps
#9 shield_pages-add_config_page-2780215-9.patch8.85 KBalan-ps
#9 interdiff-2780215-7-9.txt1.17 KBalan-ps
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

naveenvalecha created an issue. See original summary.

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha at Acquia commented
Manjit.Singh’s picture

Manjit.Singh
Primary language Hindi
Location Chandigarh
CreditAttribution: Manjit.Singh at Srijan | A Material+ Company commented
Assigned: Unassigned » Manjit.Singh
Manjit.Singh’s picture

Manjit.Singh
Primary language Hindi
Location Chandigarh
CreditAttribution: Manjit.Singh at Srijan | A Material+ Company commented
Assigned: Manjit.Singh » Unassigned
Status: Active » Needs review
FileSize
2780215-4.patch351 bytes

As this is my first routing file. Here we go :)
Let me know the changes that i have do more in this.

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha at Acquia commented
Status: Needs review » Needs work

great start!.Its only route defined. Also add the configuration form as well.

alan-ps’s picture

alan-ps CreditAttribution: alan-ps commented
Assigned: Unassigned » alan-ps

I will look at this!

alan-ps’s picture

alan-ps CreditAttribution: alan-ps commented
Assigned: alan-ps » Unassigned
Status: Needs work » Needs review
FileSize
shield_pages-add_config_page-2780215-7.patch7.58 KB

This is a patch!

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha at Acquia commented
Status: Needs review » Needs work 
+++ b/config/install/shield_pages.settings.yml
@@ -0,0 +1,10 @@
+password_settings:
+  type: 'per_page_password'
+  global_password: 0
+  session_expire_time: 0
+other_settings:
+  title: 'Shield Page -- Enter password'
+  description: 'The page you are trying to view is password protected. Please enter the password below to proceed.'
+  field_label: 'Enter Password'
+  submit_text: 'Authenticate'
+  incorrect_password_msg: 'Incorrect password!'

Define the schema/metadata of the config.

alan-ps’s picture

alan-ps CreditAttribution: alan-ps commented
Status: Needs work » Needs review
FileSize
interdiff-2780215-7-9.txt1.17 KB
shield_pages-add_config_page-2780215-9.patch8.85 KB

Fixed. Thanks.

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha at Acquia commented
Status: Needs review » Reviewed & tested by the community
FileSize
interdiff-9-10.txt1.25 KB

Looks good. Committed the patch with these extra changes.

  • naveenvalecha committed 8e53286 on 8.x-1.x authored by alan-ps 
    Issue #2780215 by alan-ps, Manjit.Singh, naveenvalecha: Add Shield Pages...
naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha at Acquia commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.