Problem/Motivation

Follow-up to #2725533: Add experimental content_moderation module. The module probably has missing test coverage. There are several @todo's in the code.

Proposed resolution

Identify missing test coverage and resolve the @todo's in sub issues.

Remaining tasks

Workflow

  1. core/modules/workflows/src/Form/WorkflowTransitionEditForm.php:93: // @todo https://www.drupal.org/node/2830584 Add some ajax to ensure that
  2. core/modules/workflows/src/Form/WorkflowTransitionAddForm.php:78: // @todo https://www.drupal.org/node/2830584 Add some ajax to ensure that
  3. core/modules/workflows/src/WorkflowTypeInterface.php:114: * @todo https://www.drupal.org/node/2579743 make part of a generic interface.
  4. core/modules/workflows/tests/modules/workflow_type_test/config/schema/workflow_type_test.schema.yml:27:# @todo, inline this straight into "workflow.type_settings.workflow_type_complex_test"
  5. core/modules/workflows/tests/src/Functional/Rest/WorkflowResourceTestBase.php:104: // @todo Update in https://www.drupal.org/node/2300677.

Content Moderation

  1. core/modules/content_moderation/src/Plugin/Field/FieldWidget/ModerationStateWidget.php:114: // @todo https://www.drupal.org/node/2779933 write a test for this.
  2. core/modules/content_moderation/src/Entity/Handler/ModerationHandler.php:37: // @todo remove this when revision and translation issues have been
  3. core/modules/content_moderation/src/ParamConverter/EntityRevisionConverter.php:32: * @todo: If the parent class is ever cleaned up to use EntityTypeManager
  4. #2973493: Remove @todo in content_moderation related to NULL values of the moderation_state field.
  5. core/modules/content_moderation/src/EntityTypeInfo.php:162: // @todo Core forgot to add a direct way to manipulate route_provider, so
  6. #2973487: Add form #state to force "Default revision" on when "Published" is checked for a new moderation state
  7. core/modules/content_moderation/tests/src/Kernel/ViewsDataIntegrationTest.php:160: // @todo I would have expected that the content_moderation_state default

User interface changes

None

API changes

None

Data model changes

None

Comments

alexpott created an issue. See original summary.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented
Issue summary: View changes

Adding a grep of all @todos.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented
Issue summary: View changes

One of the @todo's removed in #2753717: Add select field to choose moderation state on entity forms.

Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented

Opened #2859455: Remove superfluous @todos from content moderation to deal with the ones that are simply outdated and can be wholesale removed.

Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented

Opened #2861417: Correctly handle entity validation of the moderation_state field when trying to save invalid states. for "src/Plugin/Validation/Constraint/ModerationStateConstraintValidator.php:98: // @todo - what if $new_state references something that does not exist or..."

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented
Issue summary: View changes

Updating the list of @todo's in the issue summary based on the current version of the code.

I think very few of these relate to missing test coverage though.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented
Issue summary: View changes

Giving the @todos numbers

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented

content_moderation.1 is the only one which mentions "write a test" and actually links to this issue, but wondering if we can remove that whole chunk of code, it's incredibly edge case. What is does is, if an entity has a field which has the class set to ModerationStateFieldItemList, and is not moderated, the field access is set to false, but why would a field have the class set to ModerationStateFieldItemList?

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented
Issue summary: View changes

Updating the status of the CM list. Only 2 @todos left, both with patches.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.