Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
API page: https://api.drupal.org/api/drupal/core%21modules%21field%21field.api.php...
The description for hook_field_widget_form_alter()
says, for the $element
parameter:
$element: The field widget form element as constructed by hook_field_widget_form().
hook_field_widget_form()
is not anymore used in Drupal 8, since field widgets are now implemented by plugins.
I will look for the other field hooks, to see if there are other hooks that need to be updated. I guess it is the case.
Comment | File | Size | Author |
---|---|---|---|
#22 | text-changes.png | 86.99 KB | saravanaprasanth |
#17 | update-doc-comment-2779921-17.patch | 1.65 KB | apaderno |
#11 | update-doc-comment-2779921-11.patch | 1.65 KB | apaderno |
#7 | update-doc-comment-2779921-7.patch | 1.01 KB | apaderno |
#5 | update-doc-comment-2779921-5.patch | 1 KB | apaderno |
Comments
Comment #2
apadernoComment #4
apadernoComment #5
apadernoActually, this is the correct one.
Comment #6
dawehnerDo you know whether we should apply the 80 chars limit here and introduce a line break?
Comment #7
apadernoAs far as I recall, for what was explained me, the 80 character limit doesn't apply in that case. This is a re-roll, in the case I misunderstood what was told me.
Comment #8
joachim CreditAttribution: joachim at Torchbox commentedLooks good to me.
(Should this be on 8.x.2 as it's a bug rather than a feature?)
Comment #9
alexpottLet's add @see's to these docblocks then as well.
Comment #10
alexpott#7 is the correct patch - the 80 character limit applies.
Comment #11
apadernoComment #12
joachim CreditAttribution: joachim at Torchbox commentedComment #14
apadernoThe error reported by the CI job doesn't seem related to the patch.
Comment #17
apadernoComment #18
saravanaprasanth CreditAttribution: saravanaprasanth at DrupalPartners commentedComment #19
saravanaprasanth CreditAttribution: saravanaprasanth at DrupalPartners commentedHi kiamlaluno,
The above patch applied cleanly. The changes got affected in the field.api.php file.
Kindly refer the attached screenshot.
Comment #20
apaderno@saravanaprasanth The screenshot is showing a different file, not the one this patch changes.
Comment #21
saravanaprasanth CreditAttribution: saravanaprasanth at DrupalPartners commentedComment #22
saravanaprasanth CreditAttribution: saravanaprasanth at DrupalPartners commentedHi kiamlaluno,
Sorry for uploading the wrong screenshot. Please find the exact screenshot.
Comment #23
larowlan@saravanaprasanth no need to attach screenshots of patches applied, we have automated testing for that.
Comment #25
larowlanCommitted as 384a35c and pushed to 8.5.x.
Cherry-picked as 4a54723 and pushed to 8.4.x.
Comment #27
saravanaprasanth CreditAttribution: saravanaprasanth at DrupalPartners commentedHi larowlan,
Can I get credit for reviewing the above patch ?
Comment #28
larowlanHi @saravanaprasanth, I reviewed the issue in line with our policy regarding giving issue credit.
I felt that your review came under the
Examples of what will usually not receive credit
Please review those guidelines, thanks
Lee
Comment #30
larowlan