API page: https://api.drupal.org/api/drupal/core%21modules%21field%21field.api.php...

The description for hook_field_widget_form_alter() says, for the $element parameter:

$element: The field widget form element as constructed by hook_field_widget_form().

hook_field_widget_form() is not anymore used in Drupal 8, since field widgets are now implemented by plugins.

I will look for the other field hooks, to see if there are other hooks that need to be updated. I guess it is the case.

CommentFileSizeAuthor
#22 text-changes.png86.99 KBsaravanaprasanth
#19 text-change.png44.77 KBsaravanaprasanth
#17 update-doc-comment-2779921-17.patch1.65 KBapaderno
#11 update-doc-comment-2779921-11.patch1.65 KBapaderno
#7 update-doc-comment-2779921-7.patch1.01 KBapaderno
#5 update-doc-comment-2779921-5.patch1 KBapaderno
#4 update-doc-comment-2779921-4.patch1.01 KBapaderno
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kiamlaluno created an issue. See original summary.

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Issue summary: View changes

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Status: Active » Needs review
FileSize
update-doc-comment-2779921-4.patch1.01 KB
apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
FileSize
update-doc-comment-2779921-5.patch1 KB

Actually, this is the correct one.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner at Chapter Three commented

Do you know whether we should apply the 80 chars limit here and introduce a line break?

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
FileSize
update-doc-comment-2779921-7.patch1.01 KB

As far as I recall, for what was explained me, the 80 character limit doesn't apply in that case. This is a re-roll, in the case I misunderstood what was told me.

joachim’s picture

joachim CreditAttribution: joachim at Torchbox commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

(Should this be on 8.x.2 as it's a bug rather than a feature?)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Needs work

Let's add @see's to these docblocks then as well.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented

#7 is the correct patch - the 80 character limit applies.

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Status: Needs work » Needs review
FileSize
update-doc-comment-2779921-11.patch1.65 KB
joachim’s picture

joachim CreditAttribution: joachim at Torchbox commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 11: update-doc-comment-2779921-11.patch, failed testing.

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Status: Needs work » Needs review

The error reported by the CI job doesn't seem related to the patch.

Drupal\Core\Database\SchemaObjectExistsException: Table sequences already exists.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Assigned: Unassigned » apaderno
FileSize
update-doc-comment-2779921-17.patch1.65 KB
saravanaprasanth’s picture

saravanaprasanth CreditAttribution: saravanaprasanth at DrupalPartners commented
Assigned: apaderno » saravanaprasanth
saravanaprasanth’s picture

saravanaprasanth CreditAttribution: saravanaprasanth at DrupalPartners commented
Assigned: saravanaprasanth » Unassigned
Status: Needs review » Reviewed & tested by the community
FileSize
text-change.png44.77 KB

Hi kiamlaluno,

The above patch applied cleanly. The changes got affected in the field.api.php file.

Kindly refer the attached screenshot.

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented

@saravanaprasanth The screenshot is showing a different file, not the one this patch changes.

saravanaprasanth’s picture

saravanaprasanth CreditAttribution: saravanaprasanth at DrupalPartners commented
saravanaprasanth’s picture

saravanaprasanth CreditAttribution: saravanaprasanth at DrupalPartners commented
FileSize
text-changes.png86.99 KB

Hi kiamlaluno,

Sorry for uploading the wrong screenshot. Please find the exact screenshot.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan as a volunteer and at PreviousNext commented

@saravanaprasanth no need to attach screenshots of patches applied, we have automated testing for that.

  • larowlan committed 4a54723 on 8.4.x 
    Issue #2779921 by kiamlaluno, alexpott: hook_field_widget_form_alter()...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan as a volunteer and at PreviousNext commented
Version: 8.5.x-dev » 8.4.x-dev
Status: Reviewed & tested by the community » Fixed

Committed as 384a35c and pushed to 8.5.x.
Cherry-picked as 4a54723 and pushed to 8.4.x.

  • larowlan committed 384a35c on 8.5.x 
    Issue #2779921 by kiamlaluno, alexpott: hook_field_widget_form_alter()...
saravanaprasanth’s picture

saravanaprasanth CreditAttribution: saravanaprasanth at DrupalPartners commented

Hi larowlan,

Can I get credit for reviewing the above patch ?

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan as a volunteer and at PreviousNext commented

Hi @saravanaprasanth, I reviewed the issue in line with our policy regarding giving issue credit.

I felt that your review came under the Examples of what will usually not receive credit

Please review those guidelines, thanks

Lee

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan as a volunteer and at PreviousNext commented