Menu items as view modes

+    foreach ($build['#items'] as &$item) {
+      $params = $item['url']->getRouteParameters();
+      $ids[] = $item['entity_id'] = $params['node'];
+    }

$params['node'] won't exist for menu links that point at pages that aren't node pages.

This is a very interesting feature, but it seems like it would only work in certain, specific menu set ups. Menu block's options are designed to work together and on any menu.

Perhaps Menu Block could add an "module_additions" key to its config so that 3rd party module's could store form-altered settings inside the Menu Block's config? Menu block would need to add an alter hook for its build.

Checking patch config/schema/menu_block.schema.yml...
Hunk #1 succeeded at 29 (offset 12 lines).

Checking patch src/Plugin/Block/MenuBlock.php...
Hunk #1 succeeded at 174 (offset 73 lines).
error: while searching for:
    $this->configuration['expand'] = $form_state->getValue('expand');
    $this->configuration['parent'] = $form_state->getValue('parent');
    $this->configuration['suggestion'] = $form_state->getValue('suggestion');
  }

  /**

error: patch failed: src/Plugin/Block/MenuBlock.php:134
error: src/Plugin/Block/MenuBlock.php: patch does not apply

Worked on #7.
Re-rolled the patch.

Hi,

Is there any update on the D9 compatible version?

@andy_w just wonder if you have worked on any further on this patch?

Don't blocks already support third_party_settings? For example: https://www.drupal.org/project/block_titlelink/issues/2929570 and https://www.drupal.org/project/2345855/issues/2425675 are two examples of block-related modules adding third party settings to block forms to store data. I think whatever is needed for this can possibly use the same system and this change here wouldn't be necessary.