The test is failing for php 5.5 and 5.6 so I created this basic that to check if it is going to run all test without any errors.

CommentFileSizeAuthor
#2 2779191.patch755 bytespericxc
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pericxc created an issue. See original summary.

pericxc’s picture

pericxc CreditAttribution: pericxc commented
Status: Active » Needs review
FileSize
2779191.patch755 bytes

Status: Needs review » Needs work

The last submitted patch, 2: 2779191.patch, failed testing.

The last submitted patch, 2: 2779191.patch, failed testing.

pericxc’s picture

pericxc CreditAttribution: pericxc commented
Title: Test for php 5.5 and 5.6 » ALL Tests for php 5.5 and 5.6 are FAILING
Priority: Normal » Critical
pericxc’s picture

pericxc CreditAttribution: pericxc commented

including my previous patch: https://www.drupal.org/node/2770049

The last submitted patch, 2: 2779191.patch, failed testing.

The last submitted patch, 2: 2779191.patch, failed testing.

The last submitted patch, 2: 2779191.patch, failed testing.

The last submitted patch, 2: 2779191.patch, failed testing.

The last submitted patch, 2: 2779191.patch, failed testing.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext for Department of Justice & Community Safety, Victoria commented
Priority: Critical » Major

The last submitted patch, 2: 2779191.patch, failed testing.

The last submitted patch, 2: 2779191.patch, failed testing.

The last submitted patch, 2: 2779191.patch, failed testing.

pericxc’s picture

pericxc CreditAttribution: pericxc commented

No sure with is going on with tests but I download drupal 8.3.x-dev, set the vagrant box to run on php 5.6.24, and mysql 5.6.32. Run the tests and they all passed.

No issues with EntityRevisionConverter.php (second argument being passed).

I was wondering if anyone else did the same or similar test!!?

The last submitted patch, 2: 2779191.patch, failed testing.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 for Workday, Inc. commented

I'd suggest temporarily disabling 5.5 and 5.6 on issue patches, since it is making review very difficult with all patches marked as failing, and sending them back to 'needs work'. I spent a bit of time today with drupalci_testbot, but was unable to get the same failures.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 for Workday, Inc. commented
Status: Needs work » Needs review