Currently, SecureLoginManager::secureRedirect() just switches http:// for https:// . This works ok for most sites, since the browser takes care of switching to port 443 for HTTPS.

But sometimes we need to run a site on a particular port. Eg: I have a site on port 8080, with HTTPS on port 8443. In this case, Secure Login will redirect to things like https://localhost:8080 , which doesn't do the right thing.

It would be great if Secure Login could somehow specify to use the right port. Maybe by applying base_url to redirects?

Comments

vasi created an issue. See original summary.

mfb’s picture

mfb
they or he
CreditAttribution: mfb commented
Category: Feature request » Bug report

This is already supposed to work but for some reason it's not.

  • mfb committed 0266a98 on 8.x-1.x 
    Issue #2778585 by mfb, vasi: Redirects should use configured secure base...
mfb’s picture

mfb
they or he
CreditAttribution: mfb commented
Priority: Normal » Major
Status: Active » Fixed

Thanks for reporting!

This should be fixed in the dev branch.

Please test it there.

mfb’s picture

mfb
they or he
CreditAttribution: mfb commented

Anyone have time to test out the dev branch? It works in my testing, so I'm planning to release it soon...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.