API page: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Extension...

A comment for that method still references drupal_alter() that Drupal 8 doesn't define anymore.

      // If drupal_alter('module_implements') changed or added a $group, the
      // respective file needs to be included.

It should be changed as follows, since it's a hook implementation that removes or adds a group.

      // If an implementation of hook_module_implements_alter() changed or
      // added a group, the respective file needs to be included.
CommentFileSizeAuthor
#2 update-comment-2778479-1.1.patch919 bytesapaderno
#2 update-comment-2778479-1.patch918 bytesapaderno
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kiamlaluno created an issue. See original summary.

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Status: Active » Needs review
FileSize
update-comment-2778479-1.patch918 bytes
update-comment-2778479-1.1.patch919 bytes

The difference between the two patches is that one uses changed or added a $group as the current comment does, while the other one uses changed or added a group.

markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison at Chromatic commented
Status: Needs review » Reviewed & tested by the community
markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison at Chromatic commented

Personally, I prefer the changed or added a group patch.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.3.x and 8.2.x, thanks!

  • catch committed 5762aa0 on 8.3.x 
    Issue #2778479 by kiamlaluno: ModuleHandler::buildImplementationInfo()...

  • catch committed 87710f7 on 8.2.x 
    Issue #2778479 by kiamlaluno: ModuleHandler::buildImplementationInfo()...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.