Amazon Aurora support [#2777425]

When using Amazon Aurora the host must be a domain rather than an ip address because otherwise the automatic failover feature (one of the main reasons for going with Aurora) doesn't work. Also Aurora doesn't allow end users to mange innodb_checksum_algorithm, innodb_read_io_threads, or innodb_write_io_threads.

Would be nice if this could be supported.

Comment	File	Size	Author
#3	apdqc-2777425-3.patch	2.7 KB	MustangGB
#3	7.x-1.x: PHP 5.3 & MySQL 5.5, D7 18 pass PHP 5.6 & MySQL 5.5, D7 18 pass PHP 7 & MySQL 5.5, D7 18 pass
#2	apdqc-2777425-2.patch	2.74 KB	MustangGB
#2	7.x-1.x: PHP 5.3 & MySQL 5.5, D7 18 pass PHP 5.6 & MySQL 5.5, D7 18 pass PHP 7 & MySQL 5.5, D7 18 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

2 August 2016 at 09:35

MustangGB created an issue. See original summary.

Comment #2

MustangGB CreditAttribution: MustangGB commented 2 August 2016 at 09:36

Assigned:	MustangGB	» Unassigned
Status:	Active	» Needs review

File	Size
apdqc-2777425-2.patch	2.74 KB
7.x-1.x: PHP 5.3 & MySQL 5.5, D7 18 pass PHP 5.6 & MySQL 5.5, D7 18 pass PHP 7 & MySQL 5.5, D7 18 pass

Something like this perhaps.

Comment #3

MustangGB CreditAttribution: MustangGB commented 2 August 2016 at 09:38

File	Size
apdqc-2777425-3.patch	2.7 KB
7.x-1.x: PHP 5.3 & MySQL 5.5, D7 18 pass PHP 5.6 & MySQL 5.5, D7 18 pass PHP 7 & MySQL 5.5, D7 18 pass

Urm, without the mode changes.

Comment #4

MustangGB CreditAttribution: MustangGB commented 2 August 2016 at 09:38

1 file was hidden/shown/deleted

File	Size
apdqc-2777425-2.patch	2.74 KB
7.x-1.x: PHP 5.3 & MySQL 5.5, D7 18 pass PHP 5.6 & MySQL 5.5, D7 18 pass PHP 7 & MySQL 5.5, D7 18 pass

Comment #5

mikeytown2 CreditAttribution: mikeytown2 commented 3 August 2016 at 00:53

Status:

Needs review

» Reviewed & tested by the community

Looks good to me; I don't have a way to test this so if this make apdqc work on Amazon Aurora 100% then I'll go ahead and commit it. Just let me know MustangGB!

Comment #6

MustangGB CreditAttribution: MustangGB commented 3 August 2016 at 09:41

It does allow the Status Report to go all green which was my initial aim, whether or not this constitutes working 100% or not I'm not sure as I've not delved into the inner working of the module all that much. My main use case currently is the reduction of deadlocks, so if I'm getting less (or none) or these then I'm happy.

I've only used these changes in dev so far, but have tested with both MySQL and Aurora and it hasn't broken anything. I've not tested with MariaDB, however a code review should tell you that it shouldn't be effected either.

Hope that helps, I'm happy to sit on this for a while until I get the chance to roll this out into production to see if any other issues that arise, equally if you think the inner working of the module should be able to cope fine then I also don't mind if you want to commit and go the follow-up issues route (if needs be).