Problem/Motivation

Sometimes inserting token will fail because there is double quotation mark in token like this: [mailchimp_campaign|entity_type=node|entity_id=1770"|view_mode=teaser]
[mailchimp_campaign|entity_type=node|entity_id="1770"|view_mode=teaser]

Proposed resolution

Insert correct token without quotation mark(s).

CommentFileSizeAuthor
#4 Converting-token-will-fail-if-there-is-are-quotation-marks-2777207-4.patch656 bytesasrob
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

asrob created an issue. See original summary.

asrob’s picture

asrob
he/him
Primary language Hungarian
Location Hungary 🇭🇺 🇪🇺
CreditAttribution: asrob at Integral Vision Ltd commented
Title: Converting token will fail if there is a comma in title » Converting token will fail if there is quotation mark(s)
Issue summary: View changes
asrob’s picture

asrob
he/him
Primary language Hungarian
Location Hungary 🇭🇺 🇪🇺
CreditAttribution: asrob at Integral Vision Ltd commented
Title: Converting token will fail if there is quotation mark(s) » Converting token will fail if there is/are quotation mark(s)
asrob’s picture

asrob
he/him
Primary language Hungarian
Location Hungary 🇭🇺 🇪🇺
CreditAttribution: asrob at Integral Vision Ltd commented
Status: Active » Needs review
FileSize
Converting-token-will-fail-if-there-is-are-quotation-marks-2777207-4.patch656 bytes

Attached a small patch.

tikaszvince’s picture

tikaszvince CreditAttribution: tikaszvince at Integral Vision Ltd commented
Status: Needs review » Reviewed & tested by the community

Its seems ok for me. Thanks

amytswan’s picture

amytswan CreditAttribution: amytswan at ThinkShout commented

@asrob - quotation marks are not appearing for me when I go to generate tokens. Would you mind taking me through steps to reproduce the issue, i.e. how the quotations are being applied in tokens in the first place? Thanks, in advance!

JimSmith’s picture

JimSmith CreditAttribution: JimSmith commented

I can confirm the quotation marks are appearing in tokens. I have not yet tried to apply the patch.

The steps I followed were:

1. Create a new campaign, then select the list and template.

2. Select the MailChimp text format in the text field.

3. From the "Entity Type" dropdown, select "Content".

4. Start typing a title in the "Entry Title" field. Once I've selected the title of a node, quotation marks surround the title and node ID.

5. Select the appropriate view mode.

6. Click the location in the content are for inserting the token, then select the "Insert entity token" link.

7. The token that is added appears like [mailchimp_campaign|entity_type=node|entity_id=12"|view_mode=email_blog_tease]

If I manually edit the token to remove the quotation mark, the content displays correctly when the campaign is sent.

Greg Boggs’s picture

Greg Boggs
he/him
Primary language English
Location Portland Oregon
CreditAttribution: Greg Boggs at ThinkShout commented
Status: Reviewed & tested by the community » Needs review

  • ruscoe committed 8d1be3c on 8.x-1.x authored by asrob 
    Issue #2777207 by asrob, tikaszvince, amyvs, JimSmith: Converting token...
ruscoe’s picture

ruscoe CreditAttribution: ruscoe at ThinkShout for Mailchimp commented
Status: Needs review » Fixed

Works for me. Thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.