Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Basically, this is saying that the Interfaces for Entity\SmsMessageInterface and Message\SmsMessageInterface should be the same as much as possible for ease of use. Only the internal implementation / storage should differ.
Two comments on SmsProviderInterface
stand out.
/**
* Queue a standard SMS message for receiving.
*
* @todo Remove if standard message gets a direction property.
*
* @param \Drupal\sms\Message\SmsMessageInterface $sms_message
* A standard SMS message.
*/
public function queueIn(SmsMessageInterface $sms_message);
/**
* Queue a standard SMS message for sending.
*
* @todo Remove if standard message gets a direction property.
*
* @param \Drupal\sms\Message\SmsMessageInterface $sms_message
* A standard SMS message.
*/
public function queueOut(SmsMessageInterface $sms_message);
We should tidy up that @todo
Comment | File | Size | Author |
---|---|---|---|
#9 | direction-method-promote-2776751-9.patch | 15.85 KB | dpi |
#4 | direction-method-promote-2776751.patch | 13.47 KB | dpi |
Comments
Comment #2
dpiThis would involve promoting
getDirection
/setDirection
up from the entity to be a common method.I have no issue with this. What is your opinion?
Comment #3
almaudoh CreditAttribution: almaudoh commentedNo issues...
Comment #4
dpihttps://github.com/dpi/smsframework/pull/42
Comment #9
dpiconvertFromSmsMessage
not upgrading direction.Comment #13
dpi