Problem/Motivation

As a distribution we want to specify a custom url for the first page after installation.

Proposed resolution

Add a key to the profile.info.yml -> distribution[install][finish_url]

CommentFileSizeAuthor
#18 interdiff-2776605-15-18.txt688 byteschr.fritsch
#18 2776605-18.patch2.63 KBchr.fritsch
#15 interdiff-2776605-13-15.txt1.36 KBchr.fritsch
#15 2776605-15.patch1.96 KBchr.fritsch
#13 interdiff-2776605-2-13.txt778 byteschr.fritsch
#13 2776605-13.patch1.57 KBchr.fritsch
#2 make_it_possible_to-2776605-2.patch664 byteschr.fritsch
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chr.fritsch created an issue. See original summary.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
FileSize
make_it_possible_to-2776605-2.patch664 bytes
chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
Status: Active » Needs review

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and at Chapter Three commented

Seems like a total valid feature request. Is there an test distribution we could leverage to test that kind of behaviour in core?

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and at Chapter Three commented
Status: Needs review » Needs work
Issue tags: +Needs tests
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented

+1 for this feature! And +1 on the need for tests...although I have no idea how to approach that.

One question: why would this functionality be specific to distributions? Couldn't we apply it to all profiles?

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented

One question about the tests. Could that be tested in DistributionProfileTest?

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and at Chapter Three commented

Well some of the existing install profile / distribution test :)

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
Status: Needs work » Needs review
FileSize
2776605-13.patch1.57 KB
interdiff-2776605-2-13.txt778 bytes

Added a small test

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented

I like it, but I wonder if we could make the test a little more solid. For example, let's have the test distro create a node or some other URL which definitely does not exist in Drupal core, and have it redirect to that. That would prove with 100% certainty that the redirection is working as intended.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
FileSize
2776605-15.patch1.96 KB
interdiff-2776605-13-15.txt1.36 KB

What do you think about this?

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Issue tags: -Needs tests

I think that’s pretty much RTBC, buddy. Will revisit when the tests pass.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs review » Reviewed & tested by the community

Yup. Me likely. Let's land it.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
FileSize
2776605-18.patch2.63 KB
interdiff-2776605-15-18.txt688 bytes

I drafted a change record and just updated some documentation.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Thunder commented
Status: Reviewed & tested by the community » Fixed

Crediting @dawehner and @phenaproxima for suggesting tests and improvements to them.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Thunder commented

Committed 81ef7a6 and pushed to 8.6.x. Thanks!

  • alexpott committed 81ef7a6 on 8.6.x 
    Issue #2776605 by chr.fritsch, phenaproxima, dawehner: Make it possible...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.