Hi,

I have created a Drupal 8 port of this module:
https://github.com/rjjakes/hipchat

Please review and/or add me as a maintainer to this project so I can create a branch.

Thanks!

CommentFileSizeAuthor
#10 hipchat_8.x-1.x_version-2776343-10.patch15.5 KBrjjakes
#7 hipchat_8.x-1.x_version-2776343-7.patch33.16 KBrjjakes
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rjjakes created an issue. See original summary.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles at CARD.com commented

Thanks for working on this!

I don't use Drupal 8 so I'm hopeful someone else who does can test it out to help confirm it works well enough to be an 8.x-1.x release.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles at CARD.com commented

BTW, would you consider going through the project application review process so you can become a git vetted user? I believe you could use the Drupal 8 port of the module as the basis for that process.

rjjakes’s picture

rjjakes CreditAttribution: rjjakes commented

EDIT: nevermind - google was my friend :)

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles at CARD.com commented

Glad you found it :)

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles at CARD.com commented

Also, once you submit your application please post a link to it from here. That way anyone interested in supporting you in the process (like me) can follow the issue and ensure it moves along.

Thanks,
Greg

rjjakes’s picture

rjjakes CreditAttribution: rjjakes commented
FileSize
hipchat_8.x-1.x_version-2776343-7.patch33.16 KB

Here's a patch for the proposed 8.x-1.x version. Setting to "needs review".

rjjakes’s picture

rjjakes CreditAttribution: rjjakes commented
Status: Active » Needs review
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles at CARD.com commented
Title: Drupal 8 port completed » Drupal 8 port of hipchat
Status: Needs review » Needs work

Thanks for your work!

Drupal standard is not to have a license file in the git repo.

+   // Messages won't send properly without all three of these.

That looks like a mistaken indentation.

+    $hc->message_room((string)$room, (string)$site_name, (string)$message);

Did you encounter some instances where these values were not strings? Should this change be backported to d7?

+ * @param $node

Code style standard is to not add param documentation to hook implementations.

It seems you removed the hipchat_content_types feature. Any thoughts you can share on that?

rjjakes’s picture

rjjakes CreditAttribution: rjjakes commented
FileSize
hipchat_8.x-1.x_version-2776343-10.patch15.5 KB

Drupal standard is not to have a license file in the git repo.

I have removed this in the latest patch.

+ // Messages won't send properly without all three of these.
That looks like a mistaken indentation.

Fixed.

+ $hc->message_room((string)$room, (string)$site_name, (string)$message);
Did you encounter some instances where these values were not strings? Should this change be backported to d7?

I don't quite remember why I casted these values. There doesn't seem to be a reason for it as all values would be string, so I have removed in the latest patch.

+ * @param $node
Code style standard is to not add param documentation to hook implementations.

Removed.

It seems you removed the hipchat_content_types feature. Any thoughts you can share on that?

I didn't actually need that feature for my project at the time, but I have added this feature back in for the D8 patch and tested.

rjjakes’s picture

rjjakes CreditAttribution: rjjakes commented
Status: Needs work » Needs review

  • greggles committed 2eeefc5 on 8.x-1.x authored by rjjakes 
    Issue #2776343 by rjjakes: Drupal 8 port of hipchat
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles at CARD.com commented
Status: Needs review » Fixed

Cool, thanks! I've now committed this to the 8.x-1.x branch.

If you'd like to submit that branch and this issue to the project application review process to become a git vetted user I think it would be a great idea. I'd love to have your help as a maintainer, but it seems ideal for you to do that process first.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles at CARD.com commented

And the dev release is out at https://www.drupal.org/project/hipchat/releases/8.x-1.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.