See https://www.drupal.org/pift-ci-job/395325 and https://www.drupal.org/pift-ci-job/395329. For rest of the fails I have pushed the fix to 8.x-1.x http://drupalcode.org/dynamic_entity_reference/commit/?id=ef400b2
I don't want to cherry-pick this to 8.x-2.x and push because testbot will go awol.

CommentFileSizeAuthor
#4 derupdatetest_is-2775539-4.patch205.68 KBjibran
#2 derupdatetest_is-2775539-2.patch102.52 KBjibran
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jibran created an issue. See original summary.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Status: Active » Needs review
FileSize
derupdatetest_is-2775539-2.patch102.52 KB

Status: Needs review » Needs work

The last submitted patch, 2: derupdatetest_is-2775539-2.patch, failed testing.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Status: Needs work » Needs review
FileSize
derupdatetest_is-2775539-4.patch205.68 KB

I tested the upgrade path locally and it worked so updating the dump has fixed the test fails.

  • jibran committed 7e0c5a6 on 8.x-2.x 
    Issue #2775539 by jibran: DerUpdateTest is failing after 2506805
jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Status: Needs review » Fixed

Pushed the fix to 2.x

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Title: DerUpdateTest is failing after 2506805 » DerUpdateTest is failing after 2755525

Well #2506805: Non-revisionable base fields with multiple columns break revisionable entity types was not the reason. #2755525: Invoke field methods first on the current entity translation was the reason. It introduced the new test entity in core and because the dump was saved without the field config settings of that entity, the schema test started failing after the upgrade test.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Assigned: chx » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.