Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Noticed that the workflow group declared in state_test module says:
order:
label: Order
entity_type: commerce_order
That entity type is not created by this module. Would be better not to rely on entities provided by other module. See modules/state_machine/tests/modules/state_machine_test/state_machine_test.workflow_groups.yml
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | state_test_module-2774939-3.patch | 6.56 KB | mglaman |
Comments
Comment #2
moshe weitzman CreditAttribution: moshe weitzman at Acquia commentedAlso, \Drupal\state_machine_test\Guard\FulfillmentGuard depends on external stuff as well. I'm using the test module as a quick UI learning tool. Maybe this module can grow into that.
Comment #3
mglamanHere is a patch which moves the test group to entity_test, removing dependency on commerce_order.
Comment #4
bojanz CreditAttribution: bojanz at Centarro commented@moshe weitzman
The reason why the test module uses commerce_order is because I wanted it to provide a concrete example, precisely for learning purposes.
Look at #3, where Matt replaced commerce_order with entity_test, did we gain any clarity? Or did we lose it? I am not sure.
Comment #5
moshe weitzman CreditAttribution: moshe weitzman at Acquia commentedI agree that a concrete use case clarifies things. If its possible to get more concrete, then lets do that. if nobody has time to work on this more, I think it is a step forward.
Comment #7
bojanz CreditAttribution: bojanz at Centarro commentedCommitted.