Hi,

The line below breaks the site when using the site in multi - language mode.

<?php
define('CSHS_DEFAULT_NONE_LABEL', t('- Please select -'));
?>

cshs/cshs.module

Error: "Fatal error: Call to a member function getRequestUri() on null"

Steps to reproduce it:

- Install Drupal in another language than English
- Enable cshs module.

CommentFileSizeAuthor
#13 interdiff-2774919-11-13.txt1.02 KBBR0kEN
#13 cshs-fix_localized_constant-2774919-13.patch1.55 KBBR0kEN
#12 fix-localized-constant-2774919-11.patch1.4 KBmpastas
#10 fix-localized-constant-2774919-10.patch1.41 KBgngn
#9 fix-localized-constant-2774919-9.patch1.41 KBdagmar
#5 fix-localized-constant-2774919-5.patch957 bytesmpastas
#3 fix-localized-constant-2774919-2.patch950 bytesmpastas
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mpastas created an issue. See original summary.

mpastas’s picture

mpastas CreditAttribution: mpastas at Globant commented
mpastas’s picture

mpastas CreditAttribution: mpastas at Globant commented
FileSize
fix-localized-constant-2774919-2.patch950 bytes

Patch added.

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
CreditAttribution: dagmar at Globant commented
Status: Active » Needs work 
  1. +++ b/cshs.module
@@ -5,7 +5,7 @@
+define('CSHS_DEFAULT_NONE_LABEL', '- Please select -');

    If this default is not used, you could delete it. 

  2. +++ b/src/Element/CshsElement.php
@@ -27,7 +27,7 @@ class CshsElement extends Select {
+    $info['#none_label'] = t(CSHS_DEFAULT_NONE_LABEL);

    check if you can use $this->t() at this stage

mpastas’s picture

mpastas CreditAttribution: mpastas at Globant commented
FileSize
fix-localized-constant-2774919-5.patch957 bytes

You are right Mariano. Patch updated.

mpastas’s picture

mpastas CreditAttribution: mpastas at Globant commented
Status: Needs work » Needs review
dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
CreditAttribution: dagmar at Globant commented
Status: Needs review » Reviewed & tested by the community

Nice

BR0kEN’s picture

BR0kEN
Primary language Ukrainian
CreditAttribution: BR0kEN as a volunteer and at FFW for FFW commented
Status: Reviewed & tested by the community » Needs work

Constant also used in CshsOptionsFromHelper.

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
CreditAttribution: dagmar at Globant commented
Status: Needs work » Needs review
FileSize
fix-localized-constant-2774919-9.patch1.41 KB

Thanks. Here is the patch.

gngn’s picture

gngn CreditAttribution: gngn at Computer Manufaktur GmbH commented
FileSize
fix-localized-constant-2774919-10.patch1.41 KB

Just a tiny thing: #9 changes CshsOptionsFromHelper from

-        'name' => CSHS_DEFAULT_NONE_LABEL,

to

+        'name' => t('CSHS_DEFAULT_NONE_LABEL'),

We should drop the single-quotes to actually translate '- Please select -'.

+        'name' => t(CSHS_DEFAULT_NONE_LABEL),

Although I didn't see 'CSHS_DEFAULT_NONE_LABEL' on my screen - does somecode overwrites the '- Please select -' from CshsOptionsFromHelper::getOptions()?

Also I'm not sure about using t() with a constant...

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
CreditAttribution: dagmar at Globant commented
Status: Needs review » Reviewed & tested by the community

Right. Thanks @gngn.

Also I'm not sure about using t() with a constant...

This is ok, the recommendation is not use variables insde t().

mpastas’s picture

mpastas CreditAttribution: mpastas at Globant commented
FileSize
fix-localized-constant-2774919-11.patch1.4 KB

Patch updated based on dev version.

BR0kEN’s picture

BR0kEN
Primary language Ukrainian
CreditAttribution: BR0kEN as a volunteer and for FFW commented
FileSize
cshs-fix_localized_constant-2774919-13.patch1.55 KB
interdiff-2774919-11-13.txt1.02 KB

Since we are passing non string literals as argument for t(), but completely sure that value - is a string, then we have to prevent codesniffer warnings using special tags. Also, $this->t() have to be used wherever possible.

  • BR0kEN committed cf21a35 on 8.x-1.x 
    Issue #2774919 by mpastas, BR0kEN, dagmar, gngn: CSHS_DEFAULT_NONE_LABEL...
BR0kEN’s picture

BR0kEN
Primary language Ukrainian
CreditAttribution: BR0kEN as a volunteer and for FFW commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.