Active condition not working

Possible fix for an issue

New patch that fixes the issue

Looks nice, can we get some test coverage? Should just need to extend an existing one.

Added test support for bug fix

Forgot to change status to needs review

Ho, we need a combined patch (fix and test).

Adding test only patch and combined one

Yep, now it is correct, only remember to switch the uploading patch order next time :)

+++ b/src/Tests/PollCreateTest.php
@@ -25,7 +25,9 @@ class PollCreateTest extends PollTestBase {
+    $this->drupalGet('admin/content/poll', ['query' => ['status' => '2']]);
+    $this->drupalGet('admin/content/poll', ['query' => ['question' => '', 'status' => '2']]);

We shouldn't need both, can you try just using the first one?

+++ b/src/Tests/PollCreateTest.php
@@ -25,7 +25,9 @@ class PollCreateTest extends PollTestBase {
-

We need to separate this block of code with a white line. Can you also add a comment about what we are testing here?

Fix of small errors stated in comment #13

+++ b/src/Tests/PollCreateTest.php
@@ -26,9 +26,13 @@ class PollCreateTest extends PollTestBase {
+    $this->assertNoText($poll->label(), 'Poll ');

This one should say: 'Poll does not appear in poll list.'

+++ b/src/Tests/PollCreateTest.php
@@ -26,9 +26,13 @@ class PollCreateTest extends PollTestBase {
-    $this->assertText($poll->label(), 'Poll appears in poll list.');
+    $this->assertText($poll->label(), 'Poll does not appear in the poll list.');

Then this one should remain as 'Poll appears in poll list.'

Fixed issues from previous comment

+++ b/src/Tests/PollCreateTest.php
@@ -26,9 +26,13 @@ class PollCreateTest extends PollTestBase {
-    $this->assertText($poll->label(), 'Poll appears in poll list.');
+    $this->assertText($poll->label(), 'Poll appears in the Poll List.');

This is an unrelated change. Just keep the text.

New fix that corrects issue in comment #19

Please, remember to upload first the test_only patch and then the combined patch so testbot runs first the first patch and after the second one that should pass, the issue status is set as "Needs review" and you don't have to care about the status anymore ;)

I was really looking for order i put my files, however it have flipped them. Sorry for making issue again.

+++ b/src/Tests/PollCreateTest.php
@@ -26,6 +26,10 @@ class PollCreateTest extends PollTestBase {
+    $this->assertNoText($poll->label(), 'Poll does not appear in the Poll List');

It looks like your interdiff is not referring to your current patch ?

Sorry, misunderstood, my bad ^^'
Then I think it's alright :P

Looks good! I would say that this is ready.

+++ b/config/install/views.view.poll_admin.yml
@@ -4,8 +4,6 @@ dependencies:
     - user
-_core:
-  default_config_hash: sQtV9H9fDwGnxt2jTA27cAL9fT_hYWEtExVK6etjQKM
 id: poll_admin
 label: 'Poll admin'

this should not be removed, it will change, that is ok.

If it didn't generate that, then that is because you were on an old core version.

Fixed issue that 'core element' was removed due to old core version.

Nice, now it looks alright! :)

Agreed.

Still not working even after updating the module to the latest dev version.

The applied patch fixed one part of the issue but not the second part. when you filter for "Active: No" the non active polls won't appear in the results and you will get empty view instead.

I removed the unused group, and assigned the active options "Yes and No" to have associated boolean values.