Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
As per coding standard documentation at 'https://www.drupal.org/coding-standards/docs', @file tag docblock should not be there in the files that contain a namespaced class/interface/trait, whose file name is the class name with a .php extension.
Comment | File | Size | Author |
---|---|---|---|
#7 | removed-file-tag-2774615-7.patch | 6.19 KB | urvashi_vora |
removed-file-docblock-g2.patch | 6.9 KB | aks22 | |
Issue fork g2-2774615
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 2774615-remove-file-tag changes, plain diff MR !1
Comments
Comment #5
urvashi_vora CreditAttribution: urvashi_vora at Valuebound for Valuebound commentedHi,
I will work on this.
Comment #6
urvashi_vora CreditAttribution: urvashi_vora at Valuebound for Valuebound commentedI will apply a patch shortly.
Comment #7
urvashi_vora CreditAttribution: urvashi_vora at Valuebound for Valuebound commentedHi,
Please review this patch.
Thanks
Comment #9
fgmComment #10
Raveen Thakur CreditAttribution: Raveen Thakur as a volunteer and at SV Infotech for SV Infotech commentedHello guys,
** I have reviewed & implemented the patch #7. Patch #7 seems working fine for me.
** Thank you.
Comment #11
Raveen Thakur CreditAttribution: Raveen Thakur as a volunteer and at SV Infotech for SV Infotech commentedComment #13
fgmThanks for the review. Applied to today's dev HEAD.
Comment #14
Raveen Thakur CreditAttribution: Raveen Thakur as a volunteer and at SV Infotech for SV Infotech commentedYou forget to credit me @fgm
Comment #15
fgmAh, sorry, I used the default choices provided by drupal.org, which apparently doesn't take reviews into account.