Problem/Motivation

YAML form submissions paths should include the YAML form id.

Proposed resolution

This would allow blocks to target to a specific YAML form's submissions. For example, this change would allow an evaluation form to be appended to a YAML form's submission.

The below route...
/admin/structure/yamlform/results/manage/{yamlform_submission}
...will be changed to...
/admin/structure/yamlform/manage/{yamlform}/submission/{yamlform_submission}

Remaining tasks

  • Update routes.yml
  • Update YamlForm::urlRouteParameters($rel) to include yamlform id.
  • Update \Drupal\yamlform\YamlFormRequest::getRouteParameters to include YAML form ID.
  • Update submission information and navigation.
  • Fix broken tests.

Development Notes

  • Branch Name: 2773729-add-yamlform-id-to-submission-paths
  • Commit message: Issue #2773729: Add YAML form ID to submission paths
CommentFileSizeAuthor
#10 Screen Shot 2016-07-31 at 4.35.22 PM.png152.74 KBjrockowitz
#6 add_yaml_form_id_to-2773729-6.patch27.23 KBjrockowitz
#4 add_yaml_form_id_to-2773729-3.patch21.74 KBjrockowitz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jrockowitz created an issue. See original summary.

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer commented
Issue summary: View changes

  • jrockowitz committed fd5e0f3 on 2773729-add-yamlform-id-to-submission-paths 
    Issue #2773729: Add YAML form ID to submission paths
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer commented
Status: Active » Needs review
FileSize
add_yaml_form_id_to-2773729-3.patch21.74 KB

  • jrockowitz committed 24cd310 on 2773729-add-yamlform-id-to-submission-paths 
    Issue #2773729: Add YAML form ID to submission paths
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer commented
FileSize
add_yaml_form_id_to-2773729-6.patch27.23 KB

  • jrockowitz committed 2d68f01 on 8.x-1.x 
    Issue #2773729: Add YAML form ID to submission paths
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer commented
Status: Needs review » Fixed
kclarkson’s picture

kclarkson CreditAttribution: kclarkson commented
Status: Fixed » Needs work

Just downloaded the most recent dev version of the module.

-Ran an update.php
-Cleared Cache
-Submitted a New submission
-Note: I am using the Application Templated form that comes with the module

URL to submission is still: admin/structure/yamlform/results/manage/11

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer commented
Issue summary: View changes
FileSize
Screen Shot 2016-07-31 at 4.35.22 PM.png152.74 KB

I am seeing the new URL pattern. See the below screenshot.

Screenshot

Can you please try clearing your cache again?

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer commented
Status: Needs work » Needs review
kclarkson’s picture

kclarkson CreditAttribution: kclarkson commented
Status: Needs review » Fixed

yes the url is working now. Sorry for the issue change :)

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer commented
Status: Fixed » Closed (fixed)