Update PhantomJS to 2.1.1

IRC chat log with @Mixologic:

19:53:23 <WimLeers> Mixologic_: hi!
19:53:32 <WimLeers> Mixologic_: are you the right person to talk to wrt testbot's phantomjs version?
19:53:35 <Mixologic_> WimLeers: howdy
19:53:43 <Mixologic_> WimLeers: yup Im all things testbot
19:53:47 <WimLeers> awesome
19:53:50 <WimLeers> Mixologic_: https://www.drupal.org/node/2421427#comment-11446879
19:53:53 <Druplicon> https://www.drupal.org/node/2421427 => Improve the UX of Quick Editing images #2421427: Improve the UX of Quick Editing single-valued image fields => 73 comments, 7 IRC mentions
19:53:56 <WimLeers> Mixologic_: so, in a nutshell
19:54:02 <WimLeers> Mixologic_: exciting/awesome new UX feature
19:54:05 <WimLeers> Mixologic_: but tests won't pass on d.o
19:54:11 <WimLeers> Mixologic_: tests passed for samuel.mortenson locally
19:54:25 <WimLeers> Mixologic_: I debugged it and *was* able to reproduce
19:54:31 <WimLeers> Mixologic_: turns out I had older phantomjs (2.0.0)
19:54:58 <WimLeers> Mixologic_: conclusion: testbot fails because it doesn't run phantomjs 2.1.x, which doesn't include the fix for https://github.com/ariya/phantomjs/issues/12506, which landed in December 2015
19:55:02 <Mixologic_> WimLeers: yeah, phantomjs's versioning has been uh.. well, lets just say they should learn about alphas and betas.
19:55:13 <WimLeers> Mixologic_: hehe
19:55:23 <WimLeers> Mixologic_: any chance you can easily update to a new phantomjs?
19:55:29 <Mixologic_> WimLeers: so it took us a good while to find a version that worked.
19:55:31 <WimLeers> *update testbot
19:55:35 <WimLeers> uh oh
19:55:40 <Mixologic_> WimLeers: depends on the urgency.
19:56:02 <WimLeers> Mixologic_: well, this is a very prominent UX feature that *must* land before D8.2.x feature freeze… which is next week
19:56:03 <Mixologic_> WimLeers: so the composer facade is in a nice holding pattern where it works, so now Im switching focus back to drupalci
19:56:19 <WimLeers> Mixologic_: yes, I've been reading all your issue comments :)
19:56:53 <WimLeers> Mixologic_: lots of diplomatic work in the community too
19:56:55 <WimLeers> Mixologic_++
19:57:03 <Mixologic_> WimLeers: and the first thing I want to work on in drupalci is restructuring the way we handle the environment, specifcally switching from a couple of bespoke brittle containers to using a docker compose yml file to define an environment.
19:57:51 <WimLeers> Mixologic_: heh
19:58:00 <WimLeers> Mixologic_: so should I file an issue somewhere for this?
19:58:02 <Mixologic_> WimLeers: once we have that, we'll be able to adjust environments at will when testing, so if a dev wants to see if the results are different with a newer version of phantom, that wont require maintainer intervention
19:58:06 <WimLeers> Mixologic_: I don't know where the DrupalCI issue queue is
19:58:11 <Mixologic_> but yeah, if you need this pronto I can see what I can do.
19:59:17 <Mixologic_> There's really two of them. One is https://drupal.org/project/drupalci and the other is https://drupal.org/project/drupalci_testbot.  The first is pretty much for everything, the latter is where I'll move stuff if it affects the code that actually runs on the bot. Oh, and there's a third one, which is https://drupal.org/project/project_issue_file_test which is where all of the d.o. implementation lives.
20:00:14 <Mixologic_> WimLeers: my biggest concern is 2.1.1 might fix your particular issue, but may introduce other, unintended consequences. but if you ran all of the js tests locally and they pass, then thats not as big of a concern
20:03:49 <Mixologic_> WimLeers: please open an issue in https://drupal.org/project/drupalci_testbot, and let me know what version you want installed: This is where we are currently installing it: http://cgit.drupalcode.org/drupalci_testbot/tree/containers/base/php-base/Dockerfile#n78
20:04:17 <WimLeers> Mixologic_++

Relevant here: I attempted to devise a work-around, but turns out that that also doesn't work in PhantomJS. Quoting #2421427-75: Improve the UX of Quick Editing single-valued image fields:

The only possible work-around is to create a File object ourselves. See https://www.w3.org/TR/file-upload/#dfn-filelist. Concrete example at the bottom of http://thinkmoult.com/using-sahi-mink-behat-test-html5-drag-drop-file-up.... This works in Chrome for example:

new File([new Blob()], "name.png");

But in PhantomJS 2.0, and 2.1, and HEAD, this is what you get:

TypeError: FileConstructor is not a constructor (evaluating 'new File([new Blob()], "name.png")')

PhantomJS issue: https://github.com/ariya/phantomjs/issues/14247.

So, alas, there's no work-around possible.

And to prove that all JS tests work on PhantomJS 2.1.1:

wim.leers at wimleers-acquia in ~/Work/drupal-tres on 8.2.x*
$ phantomjs --version
2.1.1
wim.leers at wimleers-acquia in ~/Work/drupal-tres on 8.2.x*
$ sudo -u _www php ./vendor/bin/phpunit -c core --testsuite functional-javascript
Password:
PHPUnit 4.8.11 by Sebastian Bergmann and contributors.

...........

Time: 1.61 minutes, Memory: 7.25Mb

OK (11 tests, 82 assertions)

Thanks so much @Mixologic, this is incredibly fast! But now, please go get some sleep!

Thanks! :)