The follow warning appears when all errors are turned on:

User warning: The following module is missing from the file system: content. In order to fix this, put the module back in its original location. For more information, see the documentation page. in _drupal_trigger_error_with_delayed_logging()

This is due to Drupal 7.50 is now handling error reporting properly for missing modules. See: https://www.drupal.org/node/2487215

Core module 'content' does not exist. It is being called in salesforce_webforms.module#555

module_load_include('inc', 'content', 'includes/install');

This module was being loaded to utilize the function drupal_get_installed_schema_version(). However this function seems to be already available globally.

CommentFileSizeAuthor
#5 salesforce_webforms-module-include-warning-2773089-5.patch845 bytesnathandentzau
#3 salesforce_webforms-module-include-warning-2773089-3.patch771 bytesnathandentzau
#2 salesforce_webforms-module-include-warning-2773089-1.patch0 bytesnathandentzau
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nathandentzau created an issue. See original summary.

nathandentzau’s picture

nathandentzau
Location Rhode Island
CreditAttribution: nathandentzau commented
FileSize
salesforce_webforms-module-include-warning-2773089-1.patch0 bytes

See next comment for patch. First patch failed.

nathandentzau’s picture

nathandentzau
Location Rhode Island
CreditAttribution: nathandentzau at Oomph, Inc. commented
FileSize
salesforce_webforms-module-include-warning-2773089-3.patch771 bytes

See attached for patch.

dbcollies’s picture

dbcollies CreditAttribution: dbcollies commented
Status: Active » Needs work

I"m not certain that it's safe to assume that drupal_get_installed_schema_version() is globally available. I could certainly be mistaken, but I believe that line of code was put in place because it was not available, at least in some contexts. However, I certainly agree that the warning is a problem, and that the use of module_load_include() on a module we're not going to use, just to get to a core include, is a bad solution.

Perhaps something better would be to use this construct, based on the module_load_include() API page.

require_once DRUPAL_ROOT . '/includes/install.inc'

nathandentzau’s picture

nathandentzau
Location Rhode Island
CreditAttribution: nathandentzau at Oomph, Inc. commented
FileSize
salesforce_webforms-module-include-warning-2773089-5.patch845 bytes

Hi dbcollies,

You are correct. Some pages it loads globally and others it does not. Here's an updated patch.

dbcollies’s picture

dbcollies CreditAttribution: dbcollies commented
Status: Needs work » Patch (to be ported)

Looks good. I'll commit it when I get a chance.

dbcollies’s picture

dbcollies CreditAttribution: dbcollies commented
Status: Patch (to be ported) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.