[D8] fb_page_block

Git clone failed for http://git.drupal.org/sandbox/jeroenkool/2772039.git while invoking http://pareview.sh/pareview/httpgitdrupalorgsandboxjeroenkool2772039git

Git clone failed. Aborting.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

I reviewed your code using Coder and PHP Code Sniffer. I attach whole output, but I will point the most important errors and warnings:

fb_page_block/fb_page_block.module
3 | ERROR | [x] A closing tag is not permitted at the end of a PHP file

You don't have to use closing php tag when whole file uses PHP syntax.

fb_page_block/src/Plugin/Block/fb_page_blockBlock.php
18 | ERROR | [ ] Class name must begin with a capital letter
18 | ERROR | [ ] Class name must use UpperCamel naming without underscores

This part is crucial: class fb_page_blockBlock extends BlockBase {.... In PHP class names use UpperCamel (a.k.a. UpperCamelCase) naming convention. The same takes place in your Controller

fb_page_block/src/Controller/fb_page_blockController.php

and Form

fb_page_block/src/Form/fb_page_blockSettingsForm.php

.

Additionally, you dont have to provide your own LICENSE.* file, Drupal will take care of it automatically.

Cheers,
callpage

Automated review

http://pareview.sh/pareview/httpgitdrupalorgsandboxjeroenkool2772039git

There are still some errors.

Manual review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Is there a difference between this module and FB Likebox?

Master Branch

No: Does not follow the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and/or the README Template. But the module page description can still be improved.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

[Yes: Meets the security requirements. / No: List of security issues identified.]

Coding style & Drupal API usage

1. Module file is empty, so remove it.
2. .libraries.yml file is empty, so remove it.
3. .routing.yml file contains an unused route. Remove it
4. Remove master branch.
5. Class fb_page_blockController has a wrong name. It should be FbPageBlockController. Also the name of the file should be changed. The same thing for the other files.
6. The page defined in fb_page_blockController just returns "Test". Is this correct?
7. fb_page_blockBlock contains html code. PHP-code should not contain HTML. Can you move it to a twig template?

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.