API page: https://api.drupal.org/api/drupal/core!lib!Drupal!Core!Entity!EntityForm...

> Returns an array of supported actions for the current entity form.

This is a bit misleading. You could think this is an array of definitions, whereas in fact it's a Form API array, that is, form elements.

CommentFileSizeAuthor
#12 interdiff-4-12.txt597 bytesmsankhala
#12 2772251-12.patch962 bytesmsankhala
#4 drupal-entityform-actions-doc-2772251-4.patch998 bytesmarkpavlitski
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joachim created an issue. See original summary.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

deepakkumar14’s picture

deepakkumar14 CreditAttribution: deepakkumar14 as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented

Hi,

I think it is an array of supported actions for the current entity form.

Thanks.

markpavlitski’s picture

markpavlitski CreditAttribution: markpavlitski at Investis Digital commented
FileSize
drupal-entityform-actions-doc-2772251-4.patch998 bytes

This patch clarifies the wording and adds missing @param / @return tags.

markpavlitski’s picture

markpavlitski CreditAttribution: markpavlitski at Investis Digital commented
Status: Active » Needs review
riddhi.addweb’s picture

riddhi.addweb CreditAttribution: riddhi.addweb commented
Issue tags: +Entity forms

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Entity forms

This looks like a solid documentation improvement.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce commented
Status: Reviewed & tested by the community » Needs work 
+++ b/core/lib/Drupal/Core/Entity/EntityForm.php
@@ -217,7 +217,18 @@ protected function actionsElement(array $form, FormStateInterface $form_state) {
+   * Supported Form API action elements.

The coding standard is

Use a third person verb to start the summary of a class, interface, or method. For example: "Represents a ..." or "Provides...".

See https://www.drupal.org/docs/develop/coding-standards/api-documentation-a...

msankhala’s picture

msankhala CreditAttribution: msankhala as a volunteer and at Srijan | A Material+ Company commented
Status: Needs work » Needs review
FileSize
2772251-12.patch962 bytes
interdiff-4-12.txt597 bytes

Here is the updated patch and interdiff.

msankhala’s picture

msankhala CreditAttribution: msankhala as a volunteer and at Srijan | A Material+ Company commented
Issue tags: +Novice
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Back to rtbc as the issue found by @alexpott in #11 was fixed.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce commented
Status: Reviewed & tested by the community » Fixed

Crediting @joachim for creating this issue.

Committed and pushed 284b4202ba to 8.6.x and e38fb52c1a to 8.5.x. Thanks!

  • alexpott committed 284b420 on 8.6.x 
    Issue #2772251 by msankhala, markpavlitski, joachim: description for...

  • alexpott committed e38fb52 on 8.5.x 
    Issue #2772251 by msankhala, markpavlitski, joachim: description for...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.