Things to DO :

Change the file name and classname.
Fix the help link

Profits :
Easier to search.
InstagramBlockForm name seems like custom Block Plugin class name.

CommentFileSizeAuthor
#4 2772181-3.patch2.02 KBnaveenvalecha
#3 2772181-2.patch568 bytesnaveenvalecha
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

naveenvalecha created an issue. See original summary.

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer commented
Issue summary: View changes

Updating Issue summary.

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer commented
FileSize
2772181-2.patch568 bytes

It still N/W for help link fixing

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer commented
Status: Active » Needs review
FileSize
2772181-3.patch2.02 KB

Here's the patch that addresses the help link fixes as well.

yanniboi’s picture

yanniboi CreditAttribution: yanniboi at FreelyGive commented
Status: Needs review » Reviewed & tested by the community

Technically, refactoring a class and changing a link should be separate issues, but I am not going to make you separate the issues.

Looks good.

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer commented

refactoring a class and changing a link should be separate issues,

+1

but I am not going to make you separate the issues.

:D cool

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer commented

any updates to get this committed ?
Couple of other issues where your eyes needed #2772435: Code review using Drupal Coder #2772631: Fix Schema Errors

yanniboi’s picture

yanniboi CreditAttribution: yanniboi at FreelyGive commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.