Add tests for vocabulary hierarchy

This is a patch. Could use a test.

Is this still an issue?

Fix with test

EDIT: parent for [root] is not set #762604: Taxonomy terms list broken, term add/edit forgets it's parent

EDIT2: new issue about hierarchy #763380: Do not use \Drupal\taxonomy\TermStorageInterface::loadTree() in \Drupal\taxonomy\Form\OverviewTerms::buildForm()

Re-roll last patch suppose no need to wait debatable #763380: Do not use \Drupal\taxonomy\TermStorageInterface::loadTree() in \Drupal\taxonomy\Form\OverviewTerms::buildForm()

taxonomy.module hunk was lost

Re-roll against current HEAD

Seems this was fixed in #846524: Terms cannot be manually reordered by weight.

So patch still useful
- Adds a test
- isset() a bit faster then array_shift() + compare

I think this should be commited

#8: 277200-detect-hierachy-type-d7.patch queued for re-testing.

Sorry, I thought you said in #9 that the issue was fixed. Can we update the title and issue summary to reflect what the current patch is for?

re-roll for 7 & 8

#15: 277200-detect-hierachy-type.patch queued for re-testing.

Re-rolled patch with test

EDIT: summary updated

Attached merely removes t() from the assertion message, which is not actually translated. Reference: http://drupal.org/simpletest-tutorial-drupal7#t

Ah, I understand now. So the current patch does not include any functional changes. Instead, it includes:

1. A code cleanup.
2. An automated test to codify the correct behavior.

Patch looks good to me. Thanks @andypost for pushing this forward. :)

Thanks, committed/pushed to 8.x, moving to 7.x for backport.

Should be a simple backport.

Thanks @andypost!

That's certainly much easier to read. and yay for tests.

Committed and pushed to 7.x. Thanks!