Forgive me if I am being dense, but I am following the guidelines here for overriding settings in my sub-theme.

I have set the following inside ./config/install/mytheme.settings.yml:

settings:
  fluid_container: 1

I would expect then that the container-fluid class would be included in lieu of container. However, I don't see that being added. I have run a drush cache rebuild, several times, and have cleared browser cache.

Am I missing a step here? Thanks for a great theme, folks.

Comments

webkenny created an issue. See original summary.

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Status: Active » Closed (works as designed)

These are the install settings only. They will only be used/detected if you uninstall and reinstall your theme.

To get these changes to work semi-automatically, you will need to create config syncing directory where you also add this file. This will allow an active site to import these settings from this directory.

Essentially, you will likely technically have three places for these settings:

  1. ./docroot/themes/mytheme/config/install/mytheme.settings.yml
  2. ./config/sync/mytheme.settings.yml
  3. Overridden config set in the database.

Read https://www.drupal.org/documentation/administer/config for more information.

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Version: 8.x-3.0-rc1 » 8.x-3.x-dev
Component: Theme Settings » Documentation
Category: Bug report » Task
Status: Closed (works as designed) » Active

Actually, all that should probably be documented on that page. The new config management system is very confusing until you start to understand how it works.

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Title: container-fluid class not added when overridden in a sub-theme » Document all the places where theme setting configuration should live
webkenny’s picture

webkenny CreditAttribution: webkenny as a volunteer commented

Brilliant. Thank you, Mark. I'm more than willing to help out. I'll see if I can get an edit in this weekend.

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Status: Active » Postponed
Parent issue: » #2883714: Properly use config schema for theme settings

This needs to happen soon, but probably not until the parent issue happens.

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Status: Postponed » Active

Really not sure why I postponed this. While related to that issue, it isn't technically blocked by it.

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Title: Document all the places where theme setting configuration should live » Document all the places where theme setting configuration could live

Fix title

  • markcarver committed 2b13823 on 8.x-3.x 
    Issue #2771479 by markcarver: Document all the places where theme...
markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Status: Active » Fixed

Now live: https://drupal-bootstrap.org/api/bootstrap/docs%21Theme-Settings.md/grou...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.