This kicked off an error for me when I tried to use without colorbox enabled.

Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: You have requested a non-existent service "colorbox.attachment". in Drupal\Component\DependencyInjection\Container->get() (line 157 of core/lib/Drupal/Component/DependencyInjection/Container.php).

I might have left some other colorbox fragment sitting around but I don't think so. Enabling colorbox fixed it. Disabling both makes no error.

CommentFileSizeAuthor
#2 dependencies-2771401-1.patch708 bytesHongPong
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

HongPong created an issue. See original summary.

HongPong’s picture

HongPong CreditAttribution: HongPong as a volunteer and at kor group commented
FileSize
dependencies-2771401-1.patch708 bytes

I think this covers the issue. Cheers.

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
CreditAttribution: darvanen commented
Status: Active » Reviewed & tested by the community

Yes, it does.

Sam152’s picture

Sam152 CreditAttribution: Sam152 at PreviousNext commented

I don't know why the library dependency was removed?

  • Sam152 committed 7e4543c on 8.x-1.x 
    Issue #2771401 by Sam152: Colorbox module needs to be required
Sam152’s picture

Sam152 CreditAttribution: Sam152 at PreviousNext commented
Status: Reviewed & tested by the community » Fixed
darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
CreditAttribution: darvanen commented

Ah yes, right you are, library dependency is separately required to module dependency, my bad.

Sam152’s picture

Sam152 CreditAttribution: Sam152 at PreviousNext commented

Not a problem. Should be fixed, thanks for the nudge on this issue.

Let me know if you run into any other problems. I haven't had a chance to test this in production yet :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
CreditAttribution: darvanen commented

Just came across this issue again, any chance of a new release containing the fix? What can I do to help?

Sam152’s picture

Sam152 CreditAttribution: Sam152 at PreviousNext commented

All good, tagged another release: https://www.drupal.org/project/colorbox_inline/releases/8.x-1.0-rc2

Should be published once the bot packages it.

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
CreditAttribution: darvanen commented

Fabulous, thank you.