If you make a more link with a custom url and add a query (ie search-messages?keys={{ arguments.keys }}), views/src/Plugin/views/display/DisplayPluginBase.php will overwrite it. Patch attached

CommentFileSizeAuthor
#7 views-more-link-query-2771257-6.patch987 bytesel1_1el
#5 views-more-link-query-2771257-5.patch781 bytesel1_1el
#4 views-more-link-query-2771257-4.patch780 bytesel1_1el
views_custom_url_query_fix.patch788 bytesel1_1el
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

el1_1el created an issue. See original summary.

markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison at Chromatic commented
Status: Needs review » Needs work 
+++ b/core/modules/views/src/Plugin/views/display/DisplayPluginBase.php
@@ -2097,6 +2097,10 @@ public function renderMoreLink() {
+        //We dont want to overwrite options such as queries included in custom url

Comment does not match code style.

  1. A space should follow the opening slashes.
  2. Comments should be wrapped at 80 characters.
  3. Comments should end with proper punctuation.
markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison at Chromatic commented 
+++ b/core/modules/views/src/Plugin/views/display/DisplayPluginBase.php
@@ -2097,6 +2097,10 @@ public function renderMoreLink() {
+          $url_options = array_merge($url_options,$url->getOptions());

Per Drupal coding standards, function calls should have spaces between commas and each parameter.

el1_1el’s picture

el1_1el CreditAttribution: el1_1el commented
Status: Needs work » Needs review
FileSize
views-more-link-query-2771257-4.patch780 bytes
el1_1el’s picture

el1_1el CreditAttribution: el1_1el commented
FileSize
views-more-link-query-2771257-5.patch781 bytes

forgot the period at the end of the comment

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

el1_1el’s picture

el1_1el CreditAttribution: el1_1el commented
FileSize
views-more-link-query-2771257-6.patch987 bytes

Additionally, ampersands are not handled correctly from Url::getOptions()

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

weseze’s picture

weseze CreditAttribution: weseze commented

Bug is still present in 8.5.6

weseze’s picture

weseze CreditAttribution: weseze commented

Still present in 8.6.4. Patch from #7 still fixes it.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and at Calibrate commented
Status: Needs review » Needs work
Issue tags: +Needs tests

This new functionality does not have test-coverage. We should add test-coverage.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

weseze’s picture

weseze CreditAttribution: weseze commented

I think this was fixed in D8.8.

    if (!empty($this->view->exposed_raw_input)) {
      $url->mergeOptions(['query' => $this->view->exposed_raw_input]);
    }
el1_1el’s picture

el1_1el CreditAttribution: el1_1el commented
Status: Needs work » Closed (outdated)
Issue tags: -Needs tests

yes, i noticed that also. marking as outdated