Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I have added the feature to select which groups to send to when creating a campaign from the UI.
Comment | File | Size | Author |
---|---|---|---|
#13 | mailchimp-add_group-2769879-13.patch | 9.28 KB | VladimirAus |
| |||
#13 | interdiff-12-13.txt | 412 bytes | VladimirAus |
Comments
Comment #2
Andreas Radloff CreditAttribution: Andreas Radloff commentedComment #3
asrobI 've successfully applied this patch and looks good to me. That's why RTBC'ed!
Comment #4
asrobComment #5
asrobComment #6
Greg BoggsSetting back to needs review because it needs more testing.
Comment #7
rjacobsen0 CreditAttribution: rjacobsen0 at ThinkShout for Mailchimp commentedWhen you add a campaign on Mailchimp's website it looks like this (attached). You have the option of sending it to a Group. You can choose "Contacts match any/all of the following conditions:" And the conditions include your groups on this audience (in the picture it's "Audience for Debugging" for which you can choose "one of / all of / none of" and then select multiple items from the list box.
Providing the much simpler form on the Drupal site is not adequate. In the example "Expert / Intermediate / Beginner" are presented as radio buttons, which means you can only select one. There's no option for "one of / all of / none of". It is difficult to un-select a radio button if a stray click selects one by accident. Better to not provide this feature. If we are going to provide it, it needs more work.
Comment #8
rjacobsen0 CreditAttribution: rjacobsen0 at ThinkShout for Mailchimp commentedComment #9
firfin CreditAttribution: firfin commentedBasically a re-roll of #1 Also changed Array() to [] , fixed typos in a comments, changed tabulation from 4 to 2 spaces, removed some extraneous whitespace. Was secretly hoping this would still work so I could address the issues in #7 tomorrow.
Unfortunately, more needs to be changed apparently because this version is not storing any campaign. It just returns you to a blank 'create campaign' page after pressing save (without error / feedback unfortunately.)
BTW all the patches in this issue also incorporate the fix in #3079700: saved_segment_id attribute should be optional when a campaign has segment options
Comment #10
firfin CreditAttribution: firfin commentedComment #11
firfin CreditAttribution: firfin commentedOverhaul of patch in #2 but taking into account the concern raised in #7. Hope this is ok for you now @rjacobsen0
I would love some feedback on this patch, please try it out.
For it too work properly, it needs patches from
#3079700: saved_segment_id attribute should be optional when a campaign has segment options,#3156283: Can not save campaign without 'saved_segment_id' and #3008883: Selected list segment not showing on Mailchimp Campaign view page, causing errors hopefully these will get committed soon.Comment #12
firfin CreditAttribution: firfin commentedAdded the "Segment Operator" to give users the choice of "interestcontains", "interestcontainsall" or "interestnotcontains"
And did a bit of clean up (removed debug code etc)
No interdiff as there is no review yet of previous patch anyway.
Comment #13
VladimirAusThanks for your commits everyone!
Combining patches 11 and 12 and reviewing them.
Comment #14
VladimirAus