Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Andreas Radloff created an issue. See original summary.

asrob’s picture

Status: Needs review » Reviewed & tested by the community

I 've successfully applied this patch and looks good to me. That's why RTBC'ed!

asrob’s picture

asrob’s picture

Greg Boggs’s picture

Status: Reviewed & tested by the community » Needs review

Setting back to needs review because it needs more testing.

rjacobsen0’s picture

Status: Needs review » Needs work
FileSize
55.4 KB
27.2 KB

When you add a campaign on Mailchimp's website it looks like this (attached). You have the option of sending it to a Group. You can choose "Contacts match any/all of the following conditions:" And the conditions include your groups on this audience (in the picture it's "Audience for Debugging" for which you can choose "one of / all of / none of" and then select multiple items from the list box.

Providing the much simpler form on the Drupal site is not adequate. In the example "Expert / Intermediate / Beginner" are presented as radio buttons, which means you can only select one. There's no option for "one of / all of / none of". It is difficult to un-select a radio button if a stray click selects one by accident. Better to not provide this feature. If we are going to provide it, it needs more work.

rjacobsen0’s picture

firfin’s picture

Assigned: Andreas Radloff » firfin
Status: Needs work » Needs review

Basically a re-roll of #1 Also changed Array() to [] , fixed typos in a comments, changed tabulation from 4 to 2 spaces, removed some extraneous whitespace. Was secretly hoping this would still work so I could address the issues in #7 tomorrow.

Unfortunately, more needs to be changed apparently because this version is not storing any campaign. It just returns you to a blank 'create campaign' page after pressing save (without error / feedback unfortunately.)

BTW all the patches in this issue also incorporate the fix in #3079700: saved_segment_id attribute should be optional when a campaign has segment options

firfin’s picture

firfin’s picture

Added the "Segment Operator" to give users the choice of "interestcontains", "interestcontainsall" or "interestnotcontains"
And did a bit of clean up (removed debug code etc)

No interdiff as there is no review yet of previous patch anyway.

VladimirAus’s picture

Thanks for your commits everyone!
Combining patches 11 and 12 and reviewing them.

VladimirAus’s picture

Assigned: VladimirAus » Unassigned