Menu link of default language overwritten by translations if token module installed

How would token module affect this and why?

I guess this was introduced by #2670120: Patterns with node:menu-link tokens don't work on first node save. Pinged @larowlan.

Here's a work in progress patch with a failing test exposing the bug. I think it's close, but not quite yet. I'll work a bit more on this today and will continue tomorrow if no one else picked this up and if it isn't solved yet.

Wanted to just add a translation to the MenuLinkContent, but here we go, that should work.

Should rather check if the active langcode of the loaded MenuLinkContent is the same as the one of the Node. If not, create a new one instead. Returns to Needs work, will fix shortly.

Multilingual menu-link token replacement seems broken as well (as shown by this test failing).

So here we go with this, now adding a translation for the menu link. Nota bene the @todo.

+++ b/token.module
@@ -709,6 +709,14 @@ function token_node_menu_link_submit($entity_type, NodeInterface $node, &$form,
+        // If the loaded MenuLinkContent doesn't have a translation for the
+        // Node's active langcode, create a new translation.
+        $node_active_langcode = $node->language()->getId();
+        if (!$entity->hasTranslation($node_active_langcode)) {
+          $entity->addTranslation($node_active_langcode);
+          $entity->save();
+          $entity = \Drupal::service('entity.repository')->getTranslationFromContext($entity, $node_active_langcode);
+        }

Lets do this like _menu_ui_node_save().

There is also the isTranslatable() check. did you already create a core issue about it not working as expected when translation is disabled?

As discussed, we should at least add a (All languages) suffix on the ui if translation is disabled or have some other hint..

Thanks @Bambell, didn't get to this on Friday

Here we go. Will open a Core issue for menu link translation / "(all languages)", as discussed.

Thanks, pushed.